[Android] Tapping 'X' on Site settings pages doesn't do anything

[Brave-Matt]

Description

On Android, visiting any Site Setting page (ex. Menu --> Settings --> Site settings --> Javascript) and tapping the x on the top right of the page does not close out the menu as intended. Currently, the button is not functional and seems to do nothing. This happens for all pages inside Site Settings.

Steps to reproduce

1. Launch Brave
2. Visit Menu --> Settings --> Site settings --> Javascript or some other Site Setting page
3. Tap x on the top right

Actual result

Nothing happens.

Expected result

Menu should close out.

Issue reproduces how often

Easily/every time.

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version?
  Yes
• Can you reproduce this issue with the current Play Store Beta version?
  Yes
• Can you reproduce this issue with the current Play Store Nightly version?
  Yes

Device details

(Several)

• Install type (ARM, x86):
• Device type (Phone, Tablet, Phablet): Phone
• Android version: Android 10

Brave version

v1.15.73

Website problems only

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Additional information

[alexsafe]

Solved by brave/brave-core#8372

[stephendonner]

Verified FIXED using Brave - Beta 1.24.76, Chromium 90.0.4430.85 on Android 9.

Steps:

1. Launched Brave
2. Tapped on the 3-dots menu, --> Settings --> Site settings --> JavaScript
3. Tapped X on the top right

Confirmed the Site Settings page closed, and I was returned to the new-tab page.

example	example	example

---

Verification passed on Samsung Tab A with Android 10 running 1.24.81 x64 build

• Verified close button on Site settings page closes menu

Android.Tab.Close.settings.mp4