Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser crashes when changing internal cookie settings #12393

Closed
Brave-Matt opened this issue Oct 29, 2020 · 8 comments
Closed

Browser crashes when changing internal cookie settings #12393

Brave-Matt opened this issue Oct 29, 2020 · 8 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. crash feature/global-settings Settings at browser level independent of shields settings OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release.

Comments

@Brave-Matt
Copy link

Description

It's hard to tell exactly what is happening, but it has something to do with where exactly you click when changing internal cookie settings in brave://settings/cookies. The browser crashes when swapping between options, but there were several times where I was able to swap options without any crash. It seems more likely to occur if you click on the text directly (as opposed to clicking on the radio button itself).

That said, it seems like once I produced the crash the first time, no matter where I would click the browser crashed. I think the selected language may also have an effect on this. I can reproduce this on both macOS and Windows 10 systems.

Steps to Reproduce

  1. Launch Brave, go to brave://settings/cookies
  2. Switch from whatever setting you have currently to one of the other options (doesn't seem to matter which one).
  3. If the browser has not already crashed, try switching options by clicking on/near the text of the setting, rather than directly on the radio button.

Actual result:

browsercrash

Expected result:

No Crash.

Reproduces how often:

Easily/every time.

Brave version (brave://version info)

v1.15.76 -- v1.16.68

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Community thread here:
https://community.brave.com/t/browser-crashing-when-clicking-on-block-all-third-party-cookies/172444/5

@Brave-Matt Brave-Matt added crash feature/global-settings Settings at browser level independent of shields settings OS/Desktop labels Oct 29, 2020
@rebron
Copy link
Collaborator

rebron commented Oct 29, 2020

@Brave-Matt can you go to brave://crashes send the report and attach the id here.

@Brave-Matt
Copy link
Author

Crash 1: 88dc32a1-4e5a-4fc0-a56c-c9c419e52a69
Crash 2: b1fbc0df-520a-4508-a65b-b85581c8b2e6

@jeromebrenier
Copy link

I can confirm, Brave crashes when I change the cookie settings too.

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 3, 2020
@Brave-Matt
Copy link
Author

User seeing very similar issue:
https://community.brave.com/t/brave-crashes-to-desktop-when-allowing-steam-cookie/176340/2

@andy4117
Copy link

andy4117 commented Nov 6, 2020

This issue still exists under Version 1.16.72 Chromium: 86.0.4240.183 (Official Build) (64-Bit)

@ashdavies
Copy link

I'm getting this issue (or the same effect), from changing the cookie setting from the URL bar in Brave Beta 1.17.61, seems to happen reliably for any site.

Crash: a0e70200-cfc2-4f05-0000-000000000000

image

@iefremov
Copy link
Contributor

@Brave-Matt @ashdavies @andy4117 can anyone reproduce?

@iefremov
Copy link
Contributor

stale

@iefremov iefremov added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. crash feature/global-settings Settings at browser level independent of shields settings OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
Status: Done
Development

No branches or pull requests

6 participants