Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Cookies section of Site Settings mentions "Incognito" #12514

Closed
LaurenWags opened this issue Nov 4, 2020 · 1 comment · Fixed by brave/brave-core#10349
Closed
Assignees
Labels
branding bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@LaurenWags
Copy link
Member

Description

On the Cookies page of Site Settings one of the options mentions "Incognito". This should say "Private" or similar - basically use our branding.

Steps to reproduce

  1. Open Settings > Site Settings > Cookies

Note - when retesting, should probably check US and non-US locales to confirm translations picked up the change.

Actual result

Untitled

Expected result

Use "Private" or similar.

Issue reproduces how often

100%

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? yes 1.16.x
  • Can you reproduce this issue with the current Play Store Beta version? yes 1.17.x
  • Can you reproduce this issue with the current Play Store Nightly version? yes 1.18.x

Device details

  • Install type (ARM, x86): all
  • Device type (Phone, Tablet, Phablet): all
  • Android version: all

Brave version

1.16.74

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

cc @srirambv @anthonypkeane

@LaurenWags LaurenWags added bug QA/Yes branding OS/Android Fixes related to Android browser functionality labels Nov 4, 2020
@LaurenWags LaurenWags added this to Backlog in Android General via automation Nov 4, 2020
@anthonypkeane anthonypkeane added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 24, 2021
@anthonypkeane anthonypkeane moved this from Backlog to P2 in Android General Feb 24, 2021
@samartnik samartnik self-assigned this Oct 4, 2021
Android General automation moved this from P2 to Done/Closed Oct 5, 2021
@samartnik samartnik added this to the 1.32.x - Nightly milestone Oct 5, 2021
@stephendonner
Copy link

stephendonner commented Nov 8, 2021

Verified PASSED using Brave Beta 1.32.94, Chromium 95.0.4638.69 on a Google Pixel XL, Android 9.

Confirmed it now reads Block third-party cookies in Private.

example example
Screenshot_20211108-094852 Screenshot_20211108-095930

Verification passed on Brave v1.32.94 on Samsung Galaxy Tab S5e (Android 10.0)

Verified test plan from the description

Screenshot_20211109-130721_Brave - Beta Screenshot_20211109-131034_Brave - Beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branding bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.

5 participants