Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave rewards not being removed from URL even though disabled via settings #12533

Closed
tee4341 opened this issue Nov 5, 2020 · 4 comments · Fixed by brave/brave-core#7292
Closed

brave rewards not being removed from URL even though disabled via settings #12533

tee4341 opened this issue Nov 5, 2020 · 4 comments · Fixed by brave/brave-core#7292
Assignees
@deeppandya
Labels
feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Brave Rewards
Milestone
1.18.x - Release

Comments

@tee4341
Copy link

tee4341 commented Nov 5, 2020 •
edited

Brave nightly //// I can't turn off (brave rewards) icon in address bar. please help! me!!!
I try anything !!! please helap me!!!

https://www.img.in.th/image/sIOOAl

!!!! option. is hide not use anything!!

https://www.img.in.th/images/b5c94f2845b6715a399aa437c9738517.jpg
@tee4341 tee4341 added the OS/Android Fixes related to Android browser functionality label Nov 5, 2020
@NejcZdovc NejcZdovc added this to Backlog in Brave Rewards via automation Nov 5, 2020
@NejcZdovc
Copy link
Contributor

cc @deeppandya

@deeppandya
Copy link

@NejcZdovc is this on nightly ?

@tee4341
Copy link
Author

tee4341 commented Nov 5, 2020

yes...!!!

@srirambv srirambv mentioned this issue Nov 6, 2020
Closed
@deeppandya deeppandya mentioned this issue Dec 1, 2020
Merged
23 tasks
Brave Rewards automation moved this from Backlog to Done Dec 1, 2020
@kjozwiak kjozwiak changed the title Brave nightly //// I can't turn off (brave rewards) icon in address bar. please help! me!!! brave rewards not being removed from URL even though disabled via settings Dec 2, 2020
@LaurenWags LaurenWags mentioned this issue Dec 11, 2020
Closed
7 tasks
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Dec 14, 2020 •
edited by btlechowski

Verification passed on Samsung Galaxy J3 version 5.1.1 running Bravearm 1.18.71

Confirmed onboarding overlay/modal on panel

Screenshot_2020-12-14-21-14-41
Screenshot_2020-12-14-21-14-46
Screenshot_2020-12-14-21-14-52
Screenshot_2020-12-14-21-14-56
Screenshot_2020-12-14-21-14-58
Screenshot_2020-12-14-21-15-03
Screenshot_2020-12-14-21-15-08
Screenshot_2020-12-14-21-15-13
Screenshot_2020-12-14-21-15-19

Confirmed quick onboarding tour (pre-opt in)

Screenshot_2020-12-14-21-14-46
Screenshot_2020-12-14-21-14-52
Screenshot_2020-12-14-21-14-56
Screenshot_2020-12-14-21-14-58
Screenshot_2020-12-14-21-15-03
Screenshot_2020-12-14-21-15-08
Screenshot_2020-12-14-21-15-13
Screenshot_2020-12-14-21-15-19

Confirmed quick onboarding tour (post-opt in)

  • Confirmed clicking on "Start using Brave Rewards" launches a tour.
  • Other than the settings card, tour matches screenshots of pre-opt in tour.
  • Note, if ads are not enabled in time the "Settings" card is not shown.
Confirmed panel offers refresher tour on second panel open after starting Brave Rewards

image

Hide Brave Rewards icon
  • Confirmed able to Hide Brave Rewards icon on a clean install of 1.18.71
  • Installed 1.17.75 and hide the Brave Rewards icon. Upgraded to 1.18.71. Confirmed Brave Rewards icon is still hidden.

Verification passed on Brave v1.18.72 on Samsung Galaxy Tab S5e (Android 9.0)

Confirmed onboarding overlay/modal on panel

Screenshot_20201215-120547_Brave

Confirmed quick onboarding tour (pre-opt in)

When on the Onboarding UI, tapped on "Take a quick tour":

Onboarding 1 2 3 4 5 6 7 8
Screenshot_20201215-131848_Brave Screenshot_20201215-131857_Brave Screenshot_20201215-131904_Brave Screenshot_20201215-131913_Brave Screenshot_20201215-131919_Brave Screenshot_20201215-131924_Brave Screenshot_20201215-131943_Brave Screenshot_20201215-131948_Brave Screenshot_20201215-131954_Brave

Confirmed quick onboarding tour (post-opt in)

  • Confirmed clicking on "Start using Brave Rewards" launches a tour.
  • Other than the settings card, tour matches screenshots of pre-opt in tour.
  • Note, if ads are not enabled in time the "Settings" card is not shown.
Hide Brave Rewards icon
  • Confirmed able to Hide Brave Rewards icon on a clean install of 1.18.72
  • Installed 1.17.75 and hide the Brave Rewards icon. Upgraded to 1.18.72. Confirmed Brave Rewards icon is still hidden.

@LaurenWags LaurenWags mentioned this issue Dec 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Brave Rewards
  
Done
Milestone
1.18.x - Release
Development

Successfully merging a pull request may close this issue.

Bre onboarding 2 android brave/brave-core
6 participants
@kjozwiak @deeppandya @NejcZdovc @btlechowski @GeetaSarvadnya @tee4341