-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave News image requests should omit certain headers #12684
Comments
These are the current request headers made when we request an item Looks like we just need to remove
Is that right @fmarier ? |
With generating the request via JS |
Going to re-open this and leave it open since the |
@fmarier are you ok with moving this to a p3 since there should not be that many different buckets of users if we're only sending UA and dnt? |
P3 sounds fine. Let's not forget about it, but it doesn't need to be urgently fixed given we're not leaking very much info anymore. |
@petemill is this addressable now? I'd like to close out old issues, if possible. |
Every application using our private CDN is asked to remove the following headers from their requests:
Accept-Language
Cookie
DNT
Referer
User-Agent
I suspect we already omit the
Cookie
header when loading images in Brave Today.The text was updated successfully, but these errors were encountered: