Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Sync "Open Tabs" to "Recent tabs" #12702

Open
spiralofhope opened this issue Nov 14, 2020 · 2 comments
Open

Rename Sync "Open Tabs" to "Recent tabs" #12702

spiralofhope opened this issue Nov 14, 2020 · 2 comments
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@spiralofhope
Copy link

Description

The Sync feature "Open tabs" does not actually sync open tabs.

Saying "open tabs" plainly states that all tabs will be automatically opened on all devices so that all Brave browsers always keep the same tabs open (but perhaps not cached yet).

Since this does not actually happen, it needs to be renamed.

See also #4412 (comment)

Steps to Reproduce

  • Sync two device (Desktop and Android phone)
  • Enable sync for open tabs in both devices
  • In device 1 (Desktop), open a tab to google.com

Actual result:

  • In device 2 (Android 7), one must add a new home tab to get the top-right dots-menu to work properly
  • Tap the dot menu
  • Select "Recent tabs"
  • View the list of tabs of all connected devices.

Expected result:

  • google.com does not open as a tab in device 2

Reproduces how often:

Easily reproduced

Desktop Brave version:

Brave | 1.16.76 Chromium: 86.0.4240.198 (Official Build) (64-bit)
Revision | d8a506935fc2273cfbac5e5b629d74917d9119c7-refs/branch-heads/4240@{#1431}
OS | Windows 10 OS Version 2004 (Build 19041.630)

Android Device details:

  • Install type (ARM):
  • Device type (Phone):
  • Android version: 7.0 (also seen with 10)
@spiralofhope spiralofhope added OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 14, 2020
@spiralofhope
Copy link
Author

I've been looking and looking, and I can't even find a "recent tabs" feature for the Desktop! Is that not implemented?

Maybe a second ticket needs to be made for documenting this so that sync users know this limitation.

And a third ticket for implementing it. :)

@Germs2004
Copy link

Germs2004 commented Sep 19, 2021

my two cents: I like the current behavior where I can occasionally view the list of open tabs on my other devices without the tabs automatically opening on all my devices every time. I agree that the name "open tabs" is very unclear so renaming it would be helpful. Perhaps "viewable list of open tabs."

Google Chrome also calls this same thing "open tabs" so Brave is likely just copying that.

adithyaakrishna added a commit to adithyaakrishna/brave-core that referenced this issue Sep 25, 2021
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
adithyaakrishna added a commit to adithyaakrishna/brave-core that referenced this issue Sep 25, 2021
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants