Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet verification on Desktop and Android should parity one another #13220

Closed
Brave-Matt opened this issue Dec 16, 2020 · 22 comments · Fixed by brave/brave-core#8645
Closed
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Blocked QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@Brave-Matt
Copy link

Description

Note: This issue was carried over from internal support repo, as requested by @marshall.

“Verify wallet” flow is inconsistent between Android and desktop, and messaging/UX regarding the 25 BAT minimum can be improved. Below is a description of the current flow when pressing “verify wallet”:

Desktop flow:

  • If the user has a verified/KYCd Uphold account already, they only can simply go to Verify wallet --> Login and log into their Uphold account using standard Uphold flow, and then the wallet will be verified.
  • If the user has not yet created an uphold account/has not verified/KYCd it, they can no longer access this flow from the browser without the 25BAT minimum requirement.
    • However, if that user simply creates and verifies an Uphold account first, they can return to Verify wallet and login to their Uphold account without meeting that 25BAT requirement.

Android flow:
If a user, with or without a verified Uphold account:

  • Taps verify wallet option in Brave Rewards panel -- if they do not have 25BAT minimum in their browser wallet, they will receive a notification that 25BAT is required in order to verify/link their Android wallet with Uphold.
  • Taps verify wallet option in Brave Rewards panel -- if they have 25BAT minimum requirement, they are then taken to the Uphold signup/login flow.

Android users have a rigid restriction to wallet verification (must have 25 BAT) whereas Desktop users see more of a "suggestion" rather than facing a real restriction. This discrepancy can be confusing to users, especially now that Desktop users also receive “25 BAT minimum” messaging.

We do not want to impose a strict 25 BAT minimum because some users will want to restore existing Uphold accounts for legitimate reasons (e.g., backup/restore). However, we also do not want to encourage users with less than 25 BAT to sign up with Uphold.


Proposed changes

Proposal 1 - Changing messaging on pop-up, and make it consistent on both Desktop and Android platforms
Change messaging text to:

A 25 BAT minimum is needed to verify this browser wallet with a new Uphold account.

If you already have a verified Uphold account, use the login option to link it to your wallet.

Note: Your transactions will be visible to Uphold once you authorize; for instance, they will be able to see the recipient and amount of your tips.

Change Android notification to match messaging/notification in Desktop and display “Login” option

This will, at minimum, keep parity between platforms and also make it more clear that we are referring specifically to users who are new/do not have a current verified Uphold account. Additionally, it would allow Android users to have a reliable way to “backup” their BAT should something happen to their device.

Both platforms would display the same pop-up/messaging:
image

Proposal 2:

  1. Move the “login” button to the Backup & Restore area of Brave Rewards settings (and rename the button to “Restore verified wallet (Uphold)”).
  2. Keep 25 BAT minimum messaging.

image

This retains users’ ability to restore an existing Uphold account for backup/restore reasons, while discouraging new users from creating/linking new Uphold accounts if they have less than 25 BAT. This recasts the “login” button as a backup/restore functionality, and keeps the messaging clear.

A combination of both of proposals is another possibility (change messaging text and move UI items as described in proposal 2).

@Brave-Matt Brave-Matt added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Dec 16, 2020
@Brave-Matt
Copy link
Author

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 10, 2021

Exact report of this issue: +1 https://www.reddit.com/r/brave_browser/comments/kuf6zw/verify_wallet/

@anthonypkeane anthonypkeane added this to Backlog in Android General via automation Jan 11, 2021
@anthonypkeane anthonypkeane moved this from Backlog to P2 in Android General Jan 12, 2021
@anthonypkeane anthonypkeane added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 12, 2021
@bsclifton bsclifton removed the OS/Android Fixes related to Android browser functionality label Jan 13, 2021
@bsclifton bsclifton removed this from P2 in Android General Jan 13, 2021
@bsclifton bsclifton added this to New Issues in Rewards Jan 13, 2021
@bsclifton
Copy link
Member

bsclifton commented Jan 13, 2021

Removed OS/Android as updated messaging only affects desktop

Bigger problem here though:

  • User may have Uphold created + have lots of BAT
  • User can't link account on Desktop / Android unless they have 25 BAT

Root problem (for showing notification) is to avoiding new signs up for people that don't already have an account
@Miyayes should we allow people that have account already to sign in? (not new sign ups unless 25+ BAT)

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 15, 2021

I believe this would affect OS/Android, since Android is missing the "login" button that already exists on desktop. The solution @Brave-Matt is suggesting is that we add the same "login" button on Android (which currently does not exist on Android) in order to bring Android up to parity with desktop.

I agree that the login button should also exist on Android, in the same way it exists on desktop.

@jenn-rhim also confirmed on Nov 13, 2020 that the dialog boxes should be the same on both platforms: i.e., that both Android and desktop should have the "login" option as desktop does. It should look like this (from Jenn):

image

@bsclifton @SergeyZhukovsky

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 17, 2021

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 24, 2021

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 14, 2021

cc: @brave/android

@zenparsing zenparsing added the OS/Android Fixes related to Android browser functionality label Feb 17, 2021
@zenparsing zenparsing added this to New Issues in Brave Rewards via automation Feb 17, 2021
@zenparsing zenparsing moved this from New Issues to Backlog (Android) in Brave Rewards Feb 17, 2021
@zenparsing zenparsing removed this from New Issues in Rewards Feb 17, 2021
@anthonypkeane anthonypkeane added this to Backlog in Android General via automation Feb 17, 2021
@anthonypkeane anthonypkeane moved this from Backlog to P2 in Android General Feb 17, 2021
@deeppandya
Copy link

I believe this would affect OS/Android, since Android is missing the "login" button that already exists on desktop. The solution @Brave-Matt is suggesting is that we add the same "login" button on Android (which currently does not exist on Android) in order to bring Android up to parity with desktop.

I agree that the login button should also exist on Android, in the same way it exists on desktop.

@jenn-rhim also confirmed on Nov 13, 2020 that the dialog boxes should be the same on both platforms: i.e., that both Android and desktop should have the "login" option as desktop does. It should look like this (from Jenn):

image

@bsclifton @SergeyZhukovsky

@jenn-rhim @Miyayes i think i can follow this UI. Do you have any concerns ? what should happen when user clicks on login ?

@deeppandya
Copy link

Thanks @Miyayes I will update it.

@binocry
Copy link

binocry commented Mar 9, 2021

So any news?

@Miyayes
Copy link
Collaborator

Miyayes commented Mar 15, 2021

@LaurenWags
Copy link
Member

@deeppandya @zenparsing what are the desktop and android test plans for this issue? Adding QA/Blocked until we have a test plan for both.

@deeppandya
Copy link

@deeppandya @zenparsing what are the desktop and android test plans for this issue? Adding QA/Blocked until we have a test plan for both.
@LaurenWags I am adding the test plan for android.

@srirambv
Copy link
Contributor

@deeppandya can you confirm this is sufficient for Android #15196 (comment)? If there are any other cases to be verified please mention in the test plan and I will retest #15196

@LaurenWags
Copy link
Member

cc @zenparsing for desktop test plan. Is desktop testing needed for this issue?

@LaurenWags
Copy link
Member

@deeppandya did you make any desktop changes? wondering if I can remove the OS/Desktop label if no changes were made.

@deeppandya
Copy link

@deeppandya did you make any desktop changes? wondering if I can remove the OS/Desktop label if no changes were made.

@LaurenWags I haven't updated anything for desktop. I have added login flow for Android only.

@LaurenWags
Copy link
Member

thanks @deeppandya. Per discussion in the desktop planning mtg (5/18), I'm removing the OS/Desktop label then - lmk if you feel differently @zenparsing @rebron @kjozwiak

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.25.60 x64 Beta Build

  • Verified clicking on Verify wallet brings up the new modal
  • Verified modal mentions about min 15 BAT
  • Verified able to login to Uphold wallet even if there is no/low balance
  • Verified able to connect to an existing Uphold wallet account on Android
  • Verified if the balance is more than 15 BAT clicking on verify wallet doesn't bring the new info modal

Verification passed on Samsung Tab A with Android 10 running 1.25.60 x64 Beta Build

  • Verified clicking on Verify wallet brings up the new modal
  • Verified modal mentions about min 15 BAT
  • Verified able to login to Uphold wallet even if there is no/low balance
  • Verified able to connect to an existing Uphold wallet account on Android
  • Verified if the balance is more than 15 BAT clicking on verify wallet doesn't bring the new info modal
  • Logged Wallet login modal is stretched beyond the rewards panel #15775 for tablet UI
OnePlus 6T Samsung Tab A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Blocked QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

10 participants