Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update styles in Shields panel #1339

Closed
rebron opened this issue Sep 28, 2018 · 8 comments · Fixed by brave/brave-extension#78
Closed

Update styles in Shields panel #1339

rebron opened this issue Sep 28, 2018 · 8 comments · Fixed by brave/brave-extension#78
Assignees
@cezaraugusto
Labels
design A design change, especially one which needs input from the design team dev-concern feature/shields The overall Shields feature in Brave. l10n QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.56.x - Release ...

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 28, 2018 •
edited

Update Shields UI to match brave-core styling.

Design

Shields Up View
2dfab5b9-3790-4ff0-8cf4-29e869884112

Shields Down View
75d22077-7b46-4d0e-9d82-acc908dec024

Description

For Shields Up View, match design above with shields toggle on.
Label ‘Shields Up for this site’ with text below
‘If a site appears broken, try shields down’

Display favicon if available and first party domain name
Display total items blocked

Display 'Ads and trackers blocked' with toggle
Display number of items blocked
Toggle is Default on

Display '3rd-party cookies blocked' with drop down
Display number of items blocked
Drop down menu items:
‘3rd-party cookies blocked’ (default)
‘All cookies blocked'
‘Allow all cookies’

Display '3rd-party scripts blocked' with drop down
Display number of items blocked
Drop down menu items:
‘3rd-party scripts blocked’ (default)
‘All scripts blocked'
‘Allow all scripts’

Display '3rd-party device recognition attempts blocked' (this is fingerprinting) with drop down
Display number of items blocked
Drop down menu items:
‘3rd-party device recognition attempts blocked’ (default)
‘All device recognition attempts blocked'
‘Allow all device recognition attempts’

Display number of ‘Connections encrypted’

Link to Global Shield defaults with icon
chrome://settings/shields

For Shields Down View - Second screenshot
Shields toggle off with label 'Shields Down for this site'

Display favicon and first party domain name
Display shield ! alert icon with text:
‘You’re browsing this site without any privacy and security protections.’
Link to Global Shield defaults with icon
chrome://settings/shields
@rebron rebron added this to the Releasable builds 0.55.x milestone Sep 28, 2018
@bsclifton bsclifton added the feature/shields The overall Shields feature in Brave. label Sep 28, 2018
@rebron rebron changed the title Implement Shields UI Update styles in shields panel Sep 28, 2018
@rebron rebron changed the title Update styles in shields panel Update styles in Shields panel Sep 28, 2018
@rebron rebron added the design A design change, especially one which needs input from the design team label Sep 28, 2018
@bbondy bbondy added this to Front end UI in 0.55.x - Release Sep 28, 2018
@rebron rebron mentioned this issue Sep 30, 2018
Closed
@srirambv
Copy link
Contributor

@rebron If a site appears broken, try turning this off text doesn't make sense when shields is already off. Should probably just hide that text when shields is turned off?

@rebron
Copy link
Collaborator Author

rebron commented Oct 1, 2018

@srirambv Let me get the screenshot updated to remove that text. I didn't have it defined in the initial issue.

@rebron
Copy link
Collaborator Author

rebron commented Oct 1, 2018 •
edited

@srirambv I updated the screenshot for Shields down view. Should be accurate now.

@bbondy
Copy link
Member

bbondy commented Oct 2, 2018 •
edited

Moving redesigned shields to 0.56.x but if it's done and tested I have no problem moving it back to 0.55.x. I hope we can do that but I don't want to introduce slippage risk for the rest which was spec'ed on time, so until that is the case it will live in 0.56.x.

@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.0 (0.56.x) Oct 2, 2018
@bbondy bbondy removed this from Front end UI in 0.55.x - Release Oct 2, 2018
@bbondy bbondy added this to Front End UI in 1.0 Tasks by Category Oct 2, 2018
@rebron rebron moved this from Front End UI to Native UI in 1.0 Tasks by Category Oct 8, 2018
@rebron rebron moved this from Native UI to WebUI in 1.0 Tasks by Category Oct 8, 2018
@rebron rebron moved this from WebUI to Shields in 1.0 Tasks by Category Oct 8, 2018
@rebron
Copy link
Collaborator Author

rebron commented Oct 9, 2018

Updated screenshot and issue description.

@cezaraugusto cezaraugusto mentioned this issue Oct 11, 2018
Closed
@rebron rebron modified the milestones: 0.56.x, 0.55.x Oct 11, 2018
@rebron rebron removed this from Shields in 1.0 Tasks by Category Oct 11, 2018
@rebron rebron added this to Shields in 0.55.x - Release Oct 11, 2018
@bbondy
Copy link
Member

bbondy commented Oct 11, 2018

#1339 (comment)

@bbondy bbondy modified the milestones: 0.55.x, 0.56.x Oct 11, 2018
@bbondy bbondy removed this from Shields in 0.55.x - Release Oct 11, 2018
@rebron rebron added this to WebUI in 1.0 Tasks by Category Oct 12, 2018
@rebron rebron modified the milestones: 1.0, 0.56.x - Beta Oct 16, 2018
@rebron rebron added this to Shields in 0.56.x - Beta Oct 16, 2018
@rebron rebron removed this from Shields in 1.0 Tasks by Category Oct 16, 2018
@tildelowengrimm tildelowengrimm mentioned this issue Oct 18, 2018
Closed
@rebron rebron mentioned this issue Oct 26, 2018
Closed
@rebron rebron added the l10n label Oct 29, 2018
@rebron rebron removed this from Shields in 0.56.x - Beta Oct 29, 2018
@rebron rebron added this to Design review in Shields Oct 29, 2018
@rebron rebron moved this from Design review to Pending review in Shields Oct 29, 2018
@rebron rebron removed this from the 0.56.x - Beta milestone Oct 30, 2018
@cezaraugusto cezaraugusto mentioned this issue Oct 30, 2018
Merged
@bsclifton bsclifton added this to the 0.56.x - Beta milestone Oct 30, 2018
@bsclifton bsclifton mentioned this issue Oct 30, 2018
Merged
18 tasks
bbondy added a commit to brave/brave-core that referenced this issue Oct 30, 2018
@bbondy
Update DEPS for security audit and shields redesign
3120299 
Fix brave/brave-browser#1853
Fix brave/brave-browser#1339

Auditors: @bsclifton
bbondy added a commit to brave/brave-core that referenced this issue Oct 30, 2018
@bbondy
Update DEPS for security audit and shields redesign
404a175 
Fix brave/brave-browser#1853
Fix brave/brave-browser#1339

Auditors: @bsclifton
bbondy added a commit to brave/brave-core that referenced this issue Oct 30, 2018
@bbondy
Update DEPS for security audit and shields redesign
731719d 
Fix brave/brave-browser#1853
Fix brave/brave-browser#1339

Auditors: @bsclifton
@bbondy bbondy moved this from Pending review to Completed in Shields Oct 30, 2018
@rebron rebron removed this from Completed in Shields Oct 30, 2018
@tildelowengrimm
Copy link
Contributor

Here's the updated specification for this feature. Please QA against the spec.
https://docs.google.com/document/d/16hoEp7TcFLg4dolIPOzswzTKms6aDeDxm-jSXuVAZvc/edit#

And here's the working design spec (click for larger).
shields repaint 1

@cezaraugusto cezaraugusto mentioned this issue Oct 31, 2018
Merged
@srirambv
Copy link
Contributor

srirambv commented Nov 2, 2018 •
edited by LaurenWags

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

Shields up
image
Shields down
image

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

Shield up

image

Shield Down

image

Verified passed with

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

screen shot 2018-11-05 at 11 50 09 am

screen shot 2018-11-05 at 11 50 19 am

@kjozwiak kjozwiak mentioned this issue Nov 5, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Nov 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
design A design change, especially one which needs input from the design team dev-concern feature/shields The overall Shields feature in Brave. l10n QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.56.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

new Shields brave/brave-extension
Shields v2 GA version brave/brave-extension
9 participants
@tildelowengrimm @bbondy @kjozwiak @cezaraugusto @bsclifton @rebron @srirambv @LaurenWags @GeetaSarvadnya