Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable crowd-deny #13426

Closed
jumde opened this issue Jan 7, 2021 · 5 comments · Fixed by brave/brave-core#7559
Closed

Enable crowd-deny #13426

jumde opened this issue Jan 7, 2021 · 5 comments · Fixed by brave/brave-core#7559

Comments

@jumde
Copy link
Contributor

jumde commented Jan 7, 2021

Description

Crowd deny is in the list of blacklisted components: https://github.com/brave/brave-core/blob/5709a5804cf3c0f3f96e6c250fcb34c666d75717/chromium_src/components/component_updater/component_installer.cc#L26 - We should enable it.

More details here: https://github.com/brave/brave-browser/wiki/Brave-Components

@mherrmann
Copy link

Tested in Nightly 1.20.76 on Linux that the component appears:

image

@LaurenWags
Copy link
Member

@jumde @mherrmann should this issue be included in the release notes for 1.20.x? if so, please add release-notes/include label. If not, please add release-notes/exclude label. Thanks!

@LaurenWags
Copy link
Member

LaurenWags commented Jan 20, 2021

Verified passed with

Brave	1.20.84 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 10.15.7 (Build 19H15)

Verified test plan from brave/brave-core#7559

Clean profile

Confirmed Crowd Deny is listed on brave://components as 0.0.0.0 on clean profile.
Confirmed after ~1 minute component was installed and updated version was reflected.

Example Example
Crowd Deny - installed - clean Crowd Deny - initial - clean
Upgraded profile

Installed 1.19.82 (Dev) and confirmed Crowd Deny is listed on brave://components as 0.0.0.0.
After ~1 minute component showed Update Error.
Updated to 1.20.84 (Dev).
Confirmed Crowd Deny is listed on brave://components as 0.0.0.0.
Confirmed after ~1 minute component was installed and updated version was reflected.

Example 1.19.x Example 1.19.x Example 1.20.x Example 1.20.x
CD new 1 19 x CD - error - 1 19 x CD - New - 1 20 x Screen Shot 2021-01-20 at 11 29 35 AM

Verification passed on

Brave | 1.20.84 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Clean profile

Confirmed Crowd Deny is listed on brave://components as 0.0.0.0 on clean profile.
Confirmed after ~1 minute component was installed and updated version was reflected.

Example Example
image image
Upgraded profile

Installed 1.19.78 (Dev) and confirmed Crowd Deny is listed on brave://components as 0.0.0.0.
After ~1 minute component showed Update Error.
Updated to 1.20.84 (Dev).
Confirmed Crowd Deny is listed on brave://components as 0.0.0.0.
Confirmed after ~1 minute component was installed and updated version was reflected.

Example 1.19.x Example 1.19.x Example 1.20.x Example 1.20.x
image image image image

Verification passed on

Brave 1.20.86 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS
Clean profile

Confirmed Crowd Deny is listed on brave://components as 0.0.0.0 on clean profile.
Confirmed after ~1 minute component was installed and updated version was reflected.

Example Example
image image
Upgraded profile

Installed 1.19.x and confirmed Crowd Deny is listed on brave://components as 0.0.0.0.
After ~1 minute component showed Update Error.
Updated to 1.20.84 (Dev).
Confirmed Crowd Deny is listed on brave://components as 0.0.0.0.
Confirmed after ~1 minute component was installed and updated version was reflected.

@mherrmann
Copy link

I've added the release-notes/include label. Sorry for the trouble @LaurenWags.

@LaurenWags
Copy link
Member

thanks @mherrmann! I didn't want to make any assumptions 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants