Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy report color issue on dark theme #13455

Closed
georapbox opened this issue Jan 9, 2021 · 4 comments · Fixed by brave/brave-core#8615
Closed

Privacy report color issue on dark theme #13455

georapbox opened this issue Jan 9, 2021 · 4 comments · Fixed by brave/brave-core#8615
Assignees
Labels
feature/new-tab OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@georapbox
Copy link

georapbox commented Jan 9, 2021

Description

When opening Privacy Report panel with dark theme enabled (browser's theme se to dark manually while the OS theme is set to light), the color of the blocked trackers/ads list is dark on dark background, therefore not readable.

Steps to reproduce

  1. Set OS theme to light
  2. Set browser's theme to dark
  3. Open a new tab page
  4. Tap on Privacy stats widget to open the Privacy report panel

Actual result

The color of the trackers/ads list is dark on a dark background.

Screenshot_20210109-212251

Expected result

The color of the trackers/ads list should be light to have adequate contrast with the dark background.

Issue reproduces how often

Always

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? YES
  • Can you reproduce this issue with the current Play Store Beta version? YES
  • Can you reproduce this issue with the current Play Store Nightly version? YES

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone Motorola One (XT1941-4)
  • Android version: 10

Brave version

  • Brave 1.18.77
  • Brave - Nightly 1.20.68

Additional information

To reproduce the issue, the Privacy Report must be enabled in Settings and Privacy Stats must be enabled on the widget that sits on the New Tab Page.

@georapbox georapbox added the OS/Android Fixes related to Android browser functionality label Jan 9, 2021
@srirambv
Copy link
Contributor

Can't repro it on current PlayStore build

Is the browser theme set to dark manually or is it system default?

@srirambv srirambv added feature/new-tab needs-more-info The report requires more detail before we can decide what to do with this issue. labels Jan 12, 2021
@srirambv srirambv added this to Backlog in Android General via automation Jan 12, 2021
@georapbox
Copy link
Author

The browser's theme is set to dark manually, while the OS theme is set to light. If I set the browser's theme to follow the OS theme then it works as expected. Sorry for this omission in my description; updating now.

@georapbox
Copy link
Author

I just found out that the opposite is happening if you set the browser's theme to light and the OS theme to dark. Text becomes light on ight background.

Screenshot_20210112-102725

@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 7, 2021
@anthonypkeane anthonypkeane moved this from Backlog to P3 in Android General Apr 7, 2021
@deeppandya deeppandya self-assigned this Apr 7, 2021
Android General automation moved this from P3 to Done/Closed Apr 23, 2021
@deeppandya deeppandya added this to the 1.25.x - Beta milestone May 3, 2021
@stephendonner
Copy link

stephendonner commented May 5, 2021

Verified PASSED using Android 9, Google Pixel XL, arm64 with Brave 1.25.51

Steps:

  1. set Android theme via Settings > Display > Advanced > Device theme to Dark
  2. set Brave's theme to Light via Settings > Appearance > Theme > (o) Dark
  3. opened buzzfeed.com and tapped on View full Privacy Report ->
  4. confirmed the text under Websites, and Trackers were legible
  5. repeated the above with the other permutations of Dark and Light with each, both OS and Brave
example example
Screenshot_20210505-152701 Screenshot_20210505-152906

Verification passed on Samsung Tab A with Android 10 running 1.25.51 x64 beta build

  • Verified websites and trackers are both clearly visible on both dark and light theme
image image
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-tab OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.

6 participants