Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Sync Data preferences to Sync Options #13530

Closed
srirambv opened this issue Jan 13, 2021 · 1 comment · Fixed by brave/brave-core#8960
Closed

Change Sync Data preferences to Sync Options #13530

srirambv opened this issue Jan 13, 2021 · 1 comment · Fixed by brave/brave-core#8960
Labels
feature/settings feature/sync OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/include
Projects
Android General Sync - All platforms
Milestone
1.64.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Change Sync Data preferences to Sync Options

Steps to reproduce

  1. Create a new sync chain
  2. Shows Data Pregerences

Actual result

Expected result

Rename Data Preferences to Sync Options

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): All
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information
@srirambv srirambv added this to Backlog in Android General via automation Jan 13, 2021
@srirambv srirambv added this to Untriaged backlog in Sync - All platforms via automation Jan 13, 2021
@anthonypkeane anthonypkeane moved this from Backlog to P3 in Android General Jan 13, 2021
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 13, 2021
@rahulsnkr rahulsnkr mentioned this issue May 28, 2021
Merged
24 tasks
@jsecretan jsecretan added the priority/P4 Planned work. We expect to get to it "soon". label Nov 1, 2021
@jsecretan jsecretan moved this from Untriaged backlog to P3, P4, & P5 backlog in Sync - All platforms Nov 1, 2021
Sync - All platforms automation moved this from P3, P4, & P5 backlog to Completed Feb 5, 2024
Android General automation moved this from P3 to Done/Closed Feb 5, 2024
@bsclifton bsclifton added this to the 1.64.x - Nightly milestone Feb 5, 2024
@hffvld
Copy link
Collaborator

hffvld commented Mar 6, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP21.240119.009 release-keys
Brave build: 1.64.95 
Chromium: 122.0.6261.94 (Official Build) beta (64-bit)

STEPS:

  1. Follow the steps from Change Sync Data preferences to Sync Options #13530 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that Data Preferences was renamed to Sync Options
1 2
1 2

@kjozwiak kjozwiak mentioned this issue Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/settings feature/sync OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Sync - All platforms
  
Completed
Milestone
1.64.x - Release
Development

Successfully merging a pull request may close this issue.

Fix#13530 - Changed 'Data Preferences' to 'Sync Options' rahulsnkr/brave-core
5 participants
@jsecretan @bsclifton @anthonypkeane @srirambv @hffvld