Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Autoplay should parity Desktop #14142

Closed
rhee876527 opened this issue Feb 13, 2021 · 8 comments · Fixed by brave/brave-core#10120
Closed

Android Autoplay should parity Desktop #14142

rhee876527 opened this issue Feb 13, 2021 · 8 comments · Fixed by brave/brave-core#10120
Assignees
Labels
feature/autoplay feature-request OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@rhee876527
Copy link

Description

I know probably previous bugs have been submitted in this regard, but the information I've come across on this is either outdated or scattered and documented elsewhere.

The 1 platform (mobile version) where a toggle for disabling auto-play is mostly needed is conspicuously missing. Yet desktop version has this.

I would think the priority for enabling/disabling auto-play would be better placed on mobile rather than desktop. Is there something am missing on this peculiar omission? I also understand default chrome/Chromium as well omits auto-play control on the Android versions.

This flaw drives me nuts to say the least. Apart from burning through my mobile data, I don't get the chance to block the unneeded video content from auto playing itself.

Would appreciate any pointers as to why this conspiracy exists. Or at least any development or future plans regarding this specific feature.

@srirambv srirambv added feature-request feature/autoplay OS/Android Fixes related to Android browser functionality labels Feb 15, 2021
@srirambv
Copy link
Contributor

I don't think it is possible on Android to stop auto-play unless we deviate from Chromium and add that freature.

cc: @anthonypkeane @samartnik

@srirambv srirambv added this to Backlog in Android General via automation Feb 15, 2021
@anthonypkeane anthonypkeane moved this from Backlog to P3 in Android General May 12, 2021
@anthonypkeane anthonypkeane added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels May 12, 2021
@anthonypkeane anthonypkeane moved this from P3 to P2 in Android General May 19, 2021
@anthonypkeane anthonypkeane added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels May 19, 2021
@bsclifton
Copy link
Member

bsclifton commented May 19, 2021

See #13343 for more information

@bsclifton bsclifton changed the title Auto-play setting sorely missing on Android Android Autoplay should parity Desktop Aug 23, 2021
@mattspew
Copy link

Blocking auto-play is essential!

I can't believe it's not implemented in a browser that claims to be about privacy and data saving.

@ghost
Copy link

ghost commented Aug 24, 2021

Ok i post this here again since brave team seems to prefer solving issues by closing them.

you're really taking your time with this it's ridiculous to see how brave developers don't pay any attention to one of thier most important platforms and keep losing users this function has been added to bromite by hobbist developers and it works perfectly fine.
I suggest to take a look at thier repo and add this must-have feature to brave:
https://github.com/bromite/bromite/blob/2251acbca8218619186c410d91f95b553be989d5/build/patches/Revert-the-removal-of-an-option-to-block-autoplay.patch

https://github.com/bromite/bromite/blob/2251acbca8218619186c410d91f95b553be989d5/build/patches/Disable-unified-autoplay-feature.patch

BTW please don't make excuses that you want to use a better way to block autoplay this is an important feature that you couldn't find a way to add for a long time so just do what they did.

@ghost
Copy link

ghost commented Aug 25, 2021

This is an essential feature for a web browser firefox never remove this feature, yet chromium did but bromite devs reverted thier changes while remaining on top of chromium updates. Currently auto play wastes a lot of data and it's very annoying, it should be your top priority.

Android General automation moved this from P2 to Done/Closed Sep 27, 2021
@bsclifton bsclifton added this to the 1.32.x - Nightly milestone Sep 28, 2021
@bsclifton
Copy link
Member

Great job @wchen342 😄 Added missing milestone; do you have a test plan that QA can use?

@wchen342
Copy link

I have updated the PR with a test plan.

@stephendonner
Copy link

stephendonner commented Nov 8, 2021

Verified PASSED using Brave Beta 1.32.94, Chromium 95.0.4638.69 on a Google Pixel XL, Android 9, using the testplan from brave/brave-core#10120.

example example example example example
Screenshot_20211108-103000 Screenshot_20211108-102318 Screenshot_20211108-102601 Screenshot_20211108-102509 Screenshot_20211108-102550

Verification passed on Brave v1.32.95 on Samsung Galaxy Tab S5e (Android 10.0)

Verified testplan from brave/brave-core#10120.

Screenshot_20211111-163021_Brave - Beta Screenshot_20211111-163139_Brave - Beta Screenshot_20211111-163155_Brave - Beta Screenshot_20211111-163344_Brave - Beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/autoplay feature-request OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.

8 participants