Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon and text looks blurry on custom favourites #14485

Open
srirambv opened this issue Mar 5, 2021 · 1 comment
Open

Favicon and text looks blurry on custom favourites #14485

srirambv opened this issue Mar 5, 2021 · 1 comment
Labels
bug feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 5, 2021

Description

Favicon and text looks blurry on custom favourites

Steps to Reproduce

  1. Install 1.23.19
  2. Add a bunch of custom favourites
  3. Favicon and site name looks blurry

Actual result:

image

Expected result:

Not what it looks like

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.23.19 Chromium: 89.0.4389.72 (Official Build) nightly (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @rebron @simonhong @bsclifton @karenkliu

@rebron rebron added this to Untriaged backlog in New Tab page Mar 9, 2021
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label May 7, 2021
@rebron rebron moved this from Untriaged backlog to P4 backlog in New Tab page Jun 8, 2021
@rebron rebron moved this from P4 backlog to P3 backlog in New Tab page Jul 20, 2021
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jul 20, 2021
@bsclifton
Copy link
Member

The text blurriness would just be due to the size and OS set anti-aliasing options

Favicon blurriness is due to what we capturing on page load. Notes from #480

We should be able to read out (when loading the page or via a handler, like FaviconSource) the apple-touch-icon element/value and store in Favicon cache:
https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
No open projects
New Tab page
P3 backlog
Development

No branches or pull requests

3 participants