Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the pixelated aspect from favicons in New Tab Page #20784

Open
reidark opened this issue Jan 29, 2022 · 9 comments
Open

Reduce the pixelated aspect from favicons in New Tab Page #20784

reidark opened this issue Jan 29, 2022 · 9 comments
Labels
design A design change, especially one which needs input from the design team feature/new-tab needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@reidark
Copy link

reidark commented Jan 29, 2022

Description

The favicons in the New Tabe Page have the pixelated (low resolution) aspect. After read the #14485 It seems that not every favicon will look great in this page, because some websites don't have a good resolution favicon.

So, in order to reduce this pixelated aspect from this favicons, I propose to change the TileFavicon width/height to 64px to match the actual favicon size from chrome directory.

Steps to Reproduce

  1. Open a New Tab in Brave with pre visited websites
  2. Take a closer look in listed websites favicons

Actual result:

brave-favicons

Expected result:

brave-favicons-correct

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.34.81 Chromium: 97.0.4692.99 (Versão oficial) 64 bits
Revisão d740da257583289dbebd2eb37e8668928fac5ead-refs/branch-heads/4692@{#1461}
SO Windows 10 Version 1909 (Build 18363.2037)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? Yes
@rebron rebron added design A design change, especially one which needs input from the design team feature/new-tab needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Feb 4, 2022
@rebron
Copy link
Collaborator

rebron commented Feb 4, 2022

@bradleyrichter
Copy link

let's try it in nightly

@reidark
Copy link
Author

reidark commented Feb 7, 2022

Update: I've tested in Nightly and the pixelated aspect is there too.

Version:

Brave 1.37.29 Chromium: 98.0.4758.87 (Versão oficial) nightly 64 bits
Revisão e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
SO Windows 10 Version 20H2 (Build 19042.1466)

Here's a screenshot:
brave-nightly-favicons

@rebron rebron added this to In progress in New Tab page Feb 8, 2022
@bradleyrichter
Copy link

sorry, I meant - let's implement this change in Nightly and test it.

@ronilaukkarinen
Copy link

For me this only happens on imported bookmarks. When I visit those sites, they get higher resolution favicons after.

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label May 27, 2022
@rebron rebron moved this from In progress to P4 backlog in New Tab page May 27, 2022
@ronakkothari123
Copy link

For me this only happens on imported bookmarks. When I visit those sites, they get higher resolution favicons after.

All icons for me on the new tab page are low-resolution and therefore pixelated upon scaling up.

@biomayak
Copy link

Seems like this issue is 1 year old already.
Just installed Brave and have this issue.

MacBook M1 Pro 16, MacOS 13.4.1
Version 1.56.11 Chromium: 115.0.5790.102 (Official build), (arm64)

image

@n-splv
Copy link

n-splv commented Aug 6, 2023

+1 please fix, it's really annoying

@ronakkothari123
Copy link

I understand why this is an issue, as the HTML icon is 16 by 16. I believe that this can be fixed through webscraping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/new-tab needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
No open projects
New Tab page
P4 backlog
Development

Successfully merging a pull request may close this issue.

7 participants