Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Unstoppable Domains & ENS resolve settings into wallet settings #14516

Closed
yrliou opened this issue Mar 6, 2021 · 10 comments · Fixed by brave/brave-core#16290
Closed
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/settings feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@yrliou
Copy link
Member

yrliou commented Mar 6, 2021

They're currently under Extensions, might makes more sense in wallet settings.
brave/brave-core#8125 (comment)

@rebron
Copy link
Collaborator

rebron commented Mar 11, 2021

cc: @karenkliu

@yrliou yrliou added this to Untriaged in Wallet via automation Mar 12, 2021
@bbondy
Copy link
Member

bbondy commented Mar 14, 2021

@rebron @karenkliu How about a new DNS category after IPFS?
Either that or under Wallet.

We currently have these 2 settings:
Screen Shot 2021-03-13 at 7 33 44 PM

We'll also likely have another setting for Handshake.
And then also a 4th option which asks which provider (if any) to use for resolving non-ICANN TLDs.

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 14, 2021
@bbondy bbondy moved this from Untriaged to Brave Wallet Backlog in Wallet Mar 14, 2021
@karenkliu
Copy link

@bbondy Maybe under Wallet? Have to be wary of being too granular and adding too many sections that don't have much content. Let's think about broader themes these could fit under.

@bbondy
Copy link
Member

bbondy commented Mar 16, 2021

OK sounds good, I think it's a better fit than under extensions at least 👍

@bbondy bbondy added feature/web3/wallet Integrating Ethereum+ wallet support priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 21, 2021
@bbondy bbondy moved this from Backlog to Needs more info in Wallet Nov 3, 2021
@bbondy bbondy moved this from Needs more info to Backlog in Wallet Nov 3, 2021
@bbondy bbondy removed this from Backlog in Wallet Mar 18, 2022
@supermassive supermassive assigned supermassive and unassigned karenkliu and yrliou Jul 19, 2022
@ShivanKaul
Copy link
Collaborator

Let's make sure the ENS L2 resolution setting (in-dev) also gets migrated when this is worked on. We'll also need to update documentation (https://github.com/brave/brave-browser/wiki/ENS-offchain-lookup, or wherever that moves)

@rebron rebron added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Sep 28, 2022
@rebron rebron added this to On Deck in Settings Sep 28, 2022
@supermassive
Copy link
Collaborator

Now we have four rows related to domain resolution in brave://settings/extensions
image
and this issue blocks sec review https://github.com/brave/security/issues/1099#issuecomment-1335733756

Can we choose a new location for them?

  1. Move them to Wallet section.
  2. 1 + rename Wallet to smth like Wallet and Web3
  3. Move them to a new Web3 section.

@bbondy @bradleyrichter @aguscruiz @ShivanKaul

@bbondy
Copy link
Member

bbondy commented Dec 6, 2022

I think we should have a web3 settings page and then have different sections, one for wallet, one for decentralized DNS, one for IPFS, etc.

@bradleyrichter
Copy link
Collaborator

Mockup for a merger
image

@ShivanKaul
Copy link
Collaborator

+1

@rebron rebron moved this from On Deck to In progress in Settings Dec 9, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 15, 2022
@rebron rebron moved this from In progress to Completed in Settings Dec 20, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Linux
  • Verified steps from brave/brave-core#16290
  • Verified UD, ENS & SNS are moved under Web3 -> Web3 Domains
  • Verified still able to navigate to Wallet networks and enable/disable network
  • Verified navigation to Ipfs peers and Ipns keys still work as expected
  • Verified disable policy works as expected
14516.mp4

Verification passed on

Brave 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16290
  • Verified UD, ENS & SNS are moved under Web3 -> Web3 Domains
  • Verified still able to navigate to Wallet networks and enable/disable network
  • Verified navigation to Ipfs peers and Ipns keys still work as expected
  • Verified disable policy works as expected
14156.mp4

Verification passed on

Brave 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (arm64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16290
  • Verified UD, ENS & SNS are moved under Web3 -> Web3 Domains
  • Verified still able to navigate to Wallet networks and enable/disable network
  • Verified navigation to Ipfs peers and Ipns keys still work as expected
  • Verified disable policy works as expected
14516.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/settings feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

10 participants