Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Unstoppable Domains and ENS on Android via DoH #15159

Closed
yrliou opened this issue Apr 6, 2021 · 2 comments · Fixed by brave/brave-core#8520
Closed

Support Unstoppable Domains and ENS on Android via DoH #15159

yrliou opened this issue Apr 6, 2021 · 2 comments · Fixed by brave/brave-core#8520
Assignees
@yrliou
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Wallet
Milestone
1.24.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Apr 6, 2021 •
edited
Loading

Description

Enable the support of Unstoppable Domains and ENS via DoH on Android.

Test Plan:

  1. Open settings ->Privacy & Security -> Unstoppable Domains, the settings should be Ask.
  2. Visit brad.crypto, interstitial page for opting in should be shown, click Disable.
  3. Go to settings ->Privacy & Security -> Unstoppable Domains, the settings should be Disabled.
  4. Change it back to Ask.
  5. Visit brad.crypto again, and click Proceed this time in the interstitial page.
  6. Page should be loaded and setting should be changed to DNS over HTTPS.
    Repeat 1-6 but using almonit.eth this time.
@yrliou yrliou added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Apr 6, 2021
@yrliou yrliou self-assigned this Apr 6, 2021
@yrliou yrliou added this to Untriaged in Wallet via automation Apr 6, 2021
@yrliou yrliou changed the title Support Unstoppable Domains via DoH on Android Support Unstoppable Domains and ENS on Android Apr 8, 2021
@yrliou yrliou changed the title Support Unstoppable Domains and ENS on Android Support Unstoppable Domains and ENS on Android via DoH Apr 8, 2021
@yrliou yrliou changed the title Support Unstoppable Domains and ENS on Android via DoH Support Unstoppable Domains and ENS on Android Apr 8, 2021
@bbondy bbondy moved this from Untriaged to Brave Wallet Backlog in Wallet Apr 9, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 9, 2021
@yrliou yrliou mentioned this issue Apr 16, 2021
Merged
24 tasks
Wallet automation moved this from Brave Wallet Backlog to Done Apr 16, 2021
@yrliou yrliou added this to the 1.25.x - Nightly milestone Apr 16, 2021
@yrliou
Copy link
Member Author

yrliou commented Apr 19, 2021

Split Ethereum part to #15373 for easier tracking since we will only uplift without Ethereum option first to 1.24.x.

@yrliou yrliou changed the title Support Unstoppable Domains and ENS on Android Support Unstoppable Domains and ENS on Android via DoH Apr 19, 2021
@yrliou yrliou mentioned this issue Apr 19, 2021
Merged
7 tasks
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 29, 2021
@stephendonner
Copy link

stephendonner commented Apr 29, 2021 •
edited by srirambv
Loading

Verified PASSED using the testplan from the description, on Brave Beta 1.24.76, Chromium 90.0.4430.85 on Google Pixel XL, Android 9, arm64.

example example example example example example example example example example example example
Screenshot_20210429-095631 Screenshot_20210429-095652 Screenshot_20210429-095704 Screenshot_20210429-095727 Screenshot_20210429-095732 Screenshot_20210429-095757 Screenshot_20210429-095831 Screenshot_20210429-100111 Screenshot_20210429-100148 Screenshot_20210429-100202 Screenshot_20210429-100243 Screenshot_20210429-100253

Verification passed on Samsung Tab A with Android 10 running 1.24.81 x64 build

Verified test plan from issue description
Unstoppable Domain
Ask Disabled DNS over HTTPS
image image image
Interstitial page for Ask Failed page when Disabled Page load with DoH
image image image
ENS
Ask Disabled DNS over HTTPS
image image image
Interstitial page for Ask Failed page when Disabled Page load with DoH
image image image

@stephendonner stephendonner added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 29, 2021
This was referenced May 10, 2021
Closed
Closed
@bbondy bbondy moved this from Done to Shipped in Wallet Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
No open projects
Wallet
Closed
Milestone
1.24.x - Release
Development

Successfully merging a pull request may close this issue.

Enable support of Unstoppable Domains and ENS on Android brave/brave-core
5 participants
@stephendonner @bbondy @kjozwiak @yrliou @srirambv