Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify wallet buttons unresponsive if OS keychain or encryption permissions are not allowed #15214

Closed
Miyayes opened this issue Apr 9, 2021 · 3 comments
Closed

Verify wallet buttons unresponsive if OS keychain or encryption permissions are not allowed #15214

Miyayes opened this issue Apr 9, 2021 · 3 comments
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 9, 2021

Description

Currently, if the OS keychain is not allowed for the Brave Browser app, the "verify wallet" buttons will be unresponsive because the wallet information cannot be decrypted.

Helpful: A relevant error is already logged in the rewards logs every time this occurs (every time the "verify wallet" button is clicked in this state).

Solution

Instead of being unresponsive, we should handle this more gracefully and display some kind of error message, or trigger the system/OS's "allow/deny" dialog box.

System information

I've reproduced this on MacOS, since MacOS does have a dialog box to allow or deny. However, presumably there is a version of this on Windows too.

Related issue

Possibly related: #15002
@Miyayes Miyayes added design A design change, especially one which needs input from the design team feature/rewards design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Desktop labels Apr 9, 2021
@Miyayes Miyayes mentioned this issue Apr 15, 2021
Closed
@Miyayes Miyayes mentioned this issue Jun 11, 2021
Closed
@Miyayes
Copy link
Collaborator Author

Miyayes commented Jun 23, 2021

Might apply to other parts of the UI as well, such as ad earnings claim buttons.

@Miyayes Miyayes changed the title Verify wallet buttons unresponsive if OS keychain or encryption permissions are not allowed Verify wallet buttons unresponsive if OS keychain or encryption permissions are not allowed Jul 28, 2021
@Miyayes
Copy link
Collaborator Author

Miyayes commented Aug 16, 2021 •
edited
Loading

+1 reproduced in v1.30.x with the new verify wallet modal + Gemini. Pressing the wallet provider doesn't do anything.

@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 16, 2021
@Miyayes
Copy link
Collaborator Author

Miyayes commented Oct 5, 2021

Will be superseded in v1.31 with wallet encryption removal.

@Miyayes Miyayes closed this as completed Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Miyayes