Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return constant result for navigator.mimeTypes and navigator.plugins #1549

Closed
jumde opened this issue Oct 12, 2018 · 7 comments · Fixed by brave/brave-core#697
Closed

Return constant result for navigator.mimeTypes and navigator.plugins #1549

jumde opened this issue Oct 12, 2018 · 7 comments · Fixed by brave/brave-core#697
Assignees
@jumde
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields priority/P4 Planned work. We expect to get to it "soon". privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Security & Privacy Shields
Milestone
0.59.x - Release ...

Comments

@jumde
Copy link
Contributor

jumde commented Oct 12, 2018 •
edited
Loading

Navigator.mimeTypes and Navigator.plugins increases fingerprinting risk. It is disabled in browser-laptop

See here: https://trac.torproject.org/projects/tor/ticket/17207
@jumde jumde added privacy feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields labels Oct 12, 2018
@jumde jumde added this to the 0.57.x milestone Oct 12, 2018
@bbondy bbondy removed this from the 0.57.x milestone Oct 12, 2018
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 12, 2018
@bbondy
Copy link
Member

bbondy commented Oct 12, 2018

Getting away from putting things in specific milestones, so pls just assign a priority label based on work's importance and urgency.

@bbondy bbondy added this to the 1.x Backlog milestone Oct 16, 2018
@jumde jumde changed the title Return constant result for Navigator.mimeTypes Return constant result for navigator.mimeTypes and navigator.plugins Oct 18, 2018
@jumde jumde mentioned this issue Oct 18, 2018
Merged
18 tasks
@jumde jumde self-assigned this Oct 18, 2018
@jumde jumde added QA/Yes QA/Test-Plan-Specified needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Oct 18, 2018
@jumde
Copy link
Contributor Author

jumde commented Oct 22, 2018

Looks like I rushed on this one. We don't return constant result for mimeTypes and plugins in browser-laptop. This might cause web-compat issues.

May be we can put this behind the fingerprinting flag like firefox? cc: @tomlowenthal @diracdeltas

https://web.archive.org/web/20170204172033/https://bugzilla.mozilla.org/show_bug.cgi?id=1281963

@diracdeltas
Copy link
Member

We do return empty (or at least are supposed to) in browser-laptop for plugins and mimeTypes until Flash is explicitly allowed. The purpose of this is to trigger HTML5 fallback on sites that would otherwise require Flash. We should try to copy that behavior here.

(Plugins and mimeTypes should always return empty in Tor windows though. cc @riastradh-brave )

@jumde
Copy link
Contributor Author

jumde commented Oct 23, 2018

Sounds good, I'll update the PR.

@tildelowengrimm tildelowengrimm added this to P3, P4, & P5 Backlog in Security & Privacy Oct 31, 2018
@tildelowengrimm tildelowengrimm added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Oct 31, 2018
@tildelowengrimm tildelowengrimm moved this from P3, P4, & P5 Backlog to In Progress in Security & Privacy Oct 31, 2018
@tildelowengrimm tildelowengrimm added this to P3, P4, & P5 Backlog in Shields Nov 6, 2018
@tildelowengrimm tildelowengrimm moved this from In Progress to Pending review in Security & Privacy Nov 14, 2018
Security & Privacy automation moved this from Pending review to Completed Nov 21, 2018
Shields automation moved this from Feature Backlog to Completed Nov 21, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, 0.59.x - Nightly Nov 29, 2018
@bbondy
Copy link
Member

bbondy commented Nov 30, 2018

The following tests are currently failing on Windows, could you check @jumde ?

   NavigatorPluginsTest.ConstMimeTypesWithFlash (../../brave/chromium_src/third_party/blink/renderer/modules/plugins/navigator_pluginstest.cc:112)
    NavigatorPluginsTest.ConstPluginsWithFlash (../../brave/chromium_src/third_party/blink/renderer/modules/plugins/navigator_pluginstest.cc:96)

@jumde
Copy link
Contributor Author

jumde commented Nov 30, 2018

Checking!

@srirambv
Copy link
Contributor

srirambv commented Jan 2, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

image

  • Verified only non flash test steps for Linux

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7

Used test plan from brave/brave-core#697

With flash on
image

With flash off
image

With flash on in tor:
image

Verified passed with

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Flash not installed:
screen shot 2019-01-08 at 3 34 21 pm

Flash installed and enabled:
screen shot 2019-01-08 at 3 39 29 pm

Tor Window:
screen shot 2019-01-08 at 3 41 05 pm

@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
@tomayac tomayac mentioned this issue Jan 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jumde jumde

Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields priority/P4 Planned work. We expect to get to it "soon". privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Security & Privacy
  
Completed
Shields
  
Completed
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Issue 1549: Return constant results for navigator.plugins and navigator.mimeTypes brave/brave-core
7 participants
@diracdeltas @tildelowengrimm @bbondy @jumde @srirambv @LaurenWags @btlechowski