Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave tab crashes on youtube when it's memory footprint reaches 4GB #16136

Closed
EnderShadow opened this issue May 29, 2021 · 9 comments
Closed
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. crash needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop

Comments

@EnderShadow
Copy link

EnderShadow commented May 29, 2021

Description

When watching youtube streams with many chat messages the tab will crash with a SIG_TRAP exception. This happens once the memory footprint for the tab reaches 4GB as seen in brave's task manager. This issue has also been happening for a while.

Steps to Reproduce

  1. Watch a live stream from a popular streamer (for example, Ina from Hololive EN)
  2. Wait until the tab's memory footprint reaches 4GB

Actual result:

The tab crashes usually with a SIG_TRAP exception

Expected result:

The tab does not crash

Reproduces how often:

This easily reproduces.

Brave version (brave://version info)

Brave: 1.24.86 Chromium: 90.0.4430.212 (Official Build) (64-bit)
Revision: e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS: Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Untested
  • Can you reproduce this issue with the nightly channel? Untested

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

This may occur when the tab reaches 4GB usage in general, but I haven't tested that. It's also possible that this is youtube.com/sw.js causing the issue.

@ryanbr
Copy link

ryanbr commented May 30, 2021

Does adding ||youtube.com/sw.js into brave://adblock help? @EnderShadow

@EnderShadow
Copy link
Author

I'll test it and report back

@EnderShadow
Copy link
Author

The tab still crashed. Apparently it also occurs on past livestreams as well.

@ryanbr
Copy link

ryanbr commented May 30, 2021

How does youtube get to 4G in size? What does ≡ -> More Tools -> Task Manager show

I would try, turning off GPU acceleration via brave://settings/system, disable ALL extensions. And failing that a new profile.

Could try in a clean Brave beta install, with no extensions also.,

@EnderShadow
Copy link
Author

Hardware acceleration is already off. I'll do some more testing.

@EnderShadow
Copy link
Author

Hmm, apparently it has nothing to do with the memory reaching 4GB. I now have no clue what the cause is, just that it happens only on youtube when watching livestreams. I assume lots of comments are still the reason, but I have no clue if that's actually true.

@rebron
Copy link
Collaborator

rebron commented Oct 28, 2021

@EnderShadow Can you update to 1.31.87 and let us know if you're still seeing this issue?

@rebron rebron added crash needs-more-info The report requires more detail before we can decide what to do with this issue. labels Oct 28, 2021
@EnderShadow
Copy link
Author

Yes I will. I'll let you know if it occurs again

@rebron rebron added this to Needs Info/Waiting Upstream in General Nov 2, 2021
@EnderShadow
Copy link
Author

Yeah, I've still had it a few times. Sometimes it's a SIG_KILL signal though

@bsclifton bsclifton added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Mar 6, 2024
General automation moved this from Needs Info to Completed Mar 6, 2024
@rebron rebron removed this from Completed in General Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. crash needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop
Projects
None yet
Development

No branches or pull requests

5 participants
@ryanbr @EnderShadow @bsclifton @rebron and others