Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAT dropdown shows wallet details even before rewards is enabled #1429

Closed
srirambv opened this issue Oct 4, 2018 · 14 comments
Closed

BAT dropdown shows wallet details even before rewards is enabled #1429

srirambv opened this issue Oct 4, 2018 · 14 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 4, 2018

Description

BAT dropdown shows wallet details even before rewards is enabled

Steps to Reproduce

  1. Install beta using sudo apt install brave-browser-beta
  2. Launch browser from terminal
  3. Click on BAT button in URL bar, shows Wallet details even though rewards is not enabled. Console logs errors
[28798:28798:1004/145732.617047:ERROR:rapidjson_bat_helper.h(52)] Failed to parse:# go away 
User-agent: * 
Disallow: /  

Actual result:

https://youtu.be/p2zkM1Y5CCI

Expected result:

Should show the default dropdown to enable rewards

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes on Beta build
  • Does it reproduce on browser-laptop? N/A

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

I couldn't reproduce this on Windows. @kjozwiak @LaurenWags to check once on macOS

@btlechowski
Copy link

Not reproducible on Win7 x64

image

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

@NejcZdovc
Copy link
Contributor

can't reproduce on macOS

@NejcZdovc NejcZdovc modified the milestones: Releasable builds 0.55.x, 1.0 (0.56.x), 1.x Backlog Oct 4, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Oct 4, 2018

I cant reproduce this on a VM but consistently reproduce on laptop. Even after running rm -rf ~/.config/BraveSoftware/Brave-Browser-Beta/ and creating a new profile.

@srirambv srirambv added the needs-investigation A bug not 100% confirmed/fixed label Oct 4, 2018
@srirambv srirambv self-assigned this Oct 4, 2018
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 5, 2018
@LaurenWags
Copy link
Member

I could not reproduce on macOS using the following build:

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

@NejcZdovc NejcZdovc removed their assignment Oct 6, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Oct 9, 2018

Seems like this is only affecting Linux. @LaurenWags and @NejcZdovc couldn't reproduce on macOS and @btlechowski @srirambv couldn't reproduce the issue on Win.

@NejcZdovc NejcZdovc assigned kjozwiak and unassigned srirambv Oct 22, 2018
@kjozwiak
Copy link
Member

I couldn't reproduce using the following platforms:

  • Mint 18.3 x64 [Desktop] - Couldn't reproduce
  • Ubuntu 18.04 x64 [VM] - Couldn't reproduce

Used the following build for the above tests/checks:

Brave 0.56.6 Chromium: 70.0.3538.67 (Official Build) beta(64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux

@srirambv when you have some time, mind checking this again on your Ubuntu desktop and see if it's still an issue? If you can't reproduce it, lets close this off 👍

@srirambv
Copy link
Contributor Author

I can reproduce this on Linux Desktop Ubuntu 18.04. (clean OS install and beta)

@NejcZdovc
Copy link
Contributor

@srirambv which version you are using for testing?

@srirambv
Copy link
Contributor Author

@NejcZdovc NejcZdovc added this to Backlog in Rewards Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

7 participants