Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated text in permission dialog with lifetime options #16219

Closed
goodov opened this issue Jun 3, 2021 · 7 comments · Fixed by brave/brave-core#9006
Closed

Truncated text in permission dialog with lifetime options #16219

goodov opened this issue Jun 3, 2021 · 7 comments · Fixed by brave/brave-core#9006
Assignees
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude

Comments

@goodov
Copy link
Member

goodov commented Jun 3, 2021

Increase dialog width or add auto layout based on text with if possible for this dialog.
image

@rebron
Copy link
Collaborator

rebron commented Jun 3, 2021

cc: @karenkliu

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 3, 2021
@rebron rebron added this to In progress in General Jun 3, 2021
@karenkliu
Copy link

Current approach is to show the full dropdown option as alt text on hover over the dropdown, but it would be better to show the full text if possible.

This is what the dialog is supposed to look like if using our Brave design system styling:

image

@karenkliu karenkliu added this to To do - Buttons in Design System via automation Jun 3, 2021
@karenkliu karenkliu moved this from To do - Buttons to To do - Dropdown in Design System Jun 3, 2021
General automation moved this from In progress to Completed Jun 8, 2021
Design System automation moved this from To do - Dropdown to Done Jun 8, 2021
@goodov goodov added this to the 1.25.x - Release #4 milestone Jun 8, 2021
@goodov
Copy link
Member Author

goodov commented Jun 8, 2021

@rebron not sure what milestone exactly to set here. The task looks like a UI hotfix.

@kjozwiak
Copy link
Member

kjozwiak commented Jun 8, 2021

Moving this into 1.27.x as this landed in master via brave/brave-core#9006 and hasn't been uplifted into either 1.26.x or 1.25.x yet. Once it does land, the @brave/uplift-approvers will move the issue into the appropriate milestone.

@stephendonner
Copy link

Verified FIXED using

Brave 1.27.48 Chromium: 91.0.4472.88 (Official Build) nightly (x86_64)
Revision 109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launch Brave
  3. load permission.site
  4. click on the HTTPS toggle
  5. click on Location
  6. look at the prompt
  7. constrain the window size
  8. look again at the prompt

Confirmed in both cases the until I close this site text wasn't truncated any longer.

example example
Screen Shot 2021-06-08 at 9 51 43 AM Screen Shot 2021-06-08 at 9 56 37 AM

@kjozwiak
Copy link
Member

kjozwiak commented Jun 8, 2021

Removing QA Pass-macOS so we can do a quick spot check on 1.25.x once we spin up RC's. Verifying a single platform should be sufficient enough 👍

@stephendonner
Copy link

Verified PASSED on

Brave 1.25.72 Chromium: 91.0.4472.101 (Official Build) (x86_64)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS macOS Version 11.5 (Build 20G5033c)

Sorry, meant to verify this before we released, and just forgot, with the other CNAME bug on my to-do list.

Screen Shot 2021-06-12 at 3 48 53 AM

@rebron rebron removed this from Completed in General Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
Development

Successfully merging a pull request may close this issue.

5 participants