Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txt and json files cannot be imported via Share or import IPFS options #16713

Closed
GeetaSarvadnya opened this issue Jun 30, 2021 · 6 comments
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 30, 2021

Description

txt and json files cannot be imported via Share or import IPFS options

Steps to Reproduce

  1. Clean profile 1.27.x
  2. Enable IPFS
  3. Click on the Hamburger menu and select IPFS->Share local files using IPFS or Import the local file via the Import menu
  4. Share/import the .txt or .json file from local machine

Actual result:

txt and json files cannot be imported via Share or import IPFS options

image

image

Expected result:

txt and json files can be imported via Share or import IPFS options

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.27.84 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS Windows 10 OS Version 2004 (Build 19041.1052)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @spylogsster @rebron

@spylogsster
Copy link

spylogsster commented Jul 1, 2021

image
it works for me on 0.9.0 node and we have similar issue #16680 @GeetaSarvadnya

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jul 1, 2021

@stephendonner Yes we do have #16680, just to keep track I have logged a separate issue. The issue is working fine with --use-dev-goupdater-url 0.9.0. I will test the issue once the IPFS component version 0.9.0 is pushed into 1.27.x and close off the issue

@spylogsster spylogsster moved this from Untriaged to LocalNode in IPFS Jul 6, 2021
@lidel
Copy link

lidel commented Jul 6, 2021

Good news: ipfs-webui in go-ipfs 0.9.0 should have this bug fixed

@stephendonner
Copy link

stephendonner commented Aug 11, 2021

@GeetaSarvadnya mind re-testing with --use-dev-goupdater-url, as that'll pick up the 0.9.1 version?; this works for me using the following build with the above go-ipfs binary on https://www.lipsum.com/:

Brave 1.30.15 Chromium: 92.0.4515.131 (Official Build) nightly (x86_64)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS macOS Version 11.5.2 (Build 20G95)

Screen Shot 2021-08-11 at 4 01 37 PM

@stephendonner stephendonner added this to the IPFS node release 0.9.1 milestone Aug 18, 2021
IPFS automation moved this from LocalNode to Done Aug 18, 2021
@stephendonner
Copy link

Verified PASSED now using

Brave 1.28.105 Chromium: 92.0.4515.131 (Official Build) (x86_64)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS macOS Version 11.5.2 (Build 20G95)

and go-ipfs 0.9.1

Screen Shot 2021-08-18 at 1 11 56 PM

@GeetaSarvadnya
Copy link
Author

@stephendonner Apologies somehow missed the issue. Today I have verified the issue on Windows 10 x64 - 1.28.106 build issue is fixed and working fine with ipfs component 0.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
IPFS
  
Done
Development

No branches or pull requests

4 participants