Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ads and trackers blocked in shields v2 shows different blocked resources from v1 #1933

Closed
cezaraugusto opened this issue Oct 31, 2018 · 5 comments

Comments

@cezaraugusto
Copy link
Contributor

Description

after brave/brave-extension#78, ads/trackers blocked shows a different number of resources blocked.

Steps to Reproduce

  1. using 0.55.x, go to https://twitter.com/brianbondy
  2. check there are 5 ads/trackers blocked. click the stat and assert they are 5
  3. using 0.56.x, go repeat the steps above

Actual result:

shields indicate 5 resources blocked but blocked list shows only 4

Expected result:

should show 5

Reproduces how often:

always

Brave version (brave://version info)

0.56.x

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@cezaraugusto cezaraugusto added the feature/shields The overall Shields feature in Brave. label Oct 31, 2018
@cezaraugusto cezaraugusto added this to the 0.56.x - Beta milestone Oct 31, 2018
@cezaraugusto cezaraugusto self-assigned this Oct 31, 2018
@cezaraugusto
Copy link
Contributor Author

fixed via brave/brave-extension#79. DEPS update via brave/brave-core#773

@GeetaSarvadnya
Copy link

As per my knowledge, we will not be able to test this defect on Windows as we don't have offline installer and don't have option to install older version and upgrade it to the latest version.
@kjozwiak Please suggest if there are any ways i can test this defect on windows.

@kjozwiak
Copy link
Member

kjozwiak commented Nov 6, 2018

@GeetaSarvadnya I don't think this requires a 0.55.x -> 0.56.x update. I believe all we need to do for this issue is the following:

  • download & install 0.56.8 Chromium: 70.0.3538.77
  • visit https://twitter.com/brianbondy and ensure that Total Blocked lists 5 resources blocked and that 5 recourses are appearing under the Ads and trackers blocked list

@cezaraugusto is that correct?

@srirambv
Copy link
Contributor

srirambv commented Nov 6, 2018

Verification passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

Verified https://twitter.com/brianbondy shows total blocked items as 5

image

Went through verification using the following build under macOS 10.14 x64 - PASSED

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

@GeetaSarvadnya
Copy link

@kjozwiak Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants