Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new Rewards NTP Widget v2 design #17483

Closed
Miyayes opened this issue Aug 13, 2021 · 2 comments · Fixed by brave/brave-core#10302
Closed

Implement new Rewards NTP Widget v2 design #17483

Miyayes opened this issue Aug 13, 2021 · 2 comments · Fixed by brave/brave-core#10302
Assignees
@zenparsing
Labels
feature/rewards feature/widgets OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Brave Rewards
Milestone
1.33.x - Release

Comments

@Miyayes
Copy link
Contributor

Miyayes commented Aug 13, 2021 •
edited

Description

Implement the new Rewards NTP Widget v2 design.

Message @Miyayes or @karenkliu for spec.
@Miyayes Miyayes added this to New Issues in Brave Rewards via automation Aug 13, 2021
@Miyayes Miyayes changed the title Implement new Rewards NTP widget design Implement new Rewards NTP Widget v2 design Aug 13, 2021
@zenparsing zenparsing self-assigned this Aug 18, 2021
@zenparsing zenparsing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 18, 2021
@zenparsing zenparsing moved this from New Issues to On deck in Brave Rewards Aug 18, 2021
@zenparsing zenparsing moved this from On deck to In progress in Brave Rewards Sep 15, 2021
@zenparsing zenparsing moved this from In progress to On deck in Brave Rewards Sep 21, 2021
@Miyayes Miyayes added this to the 1.32.x - Nightly milestone Sep 21, 2021
@zenparsing zenparsing moved this from On deck to In progress in Brave Rewards Sep 29, 2021
@zenparsing zenparsing mentioned this issue Sep 29, 2021
Merged
24 tasks
Brave Rewards automation moved this from In progress to Done Oct 13, 2021
@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Test-All-Platforms labels Nov 3, 2021
@LaurenWags
Copy link
Member

LaurenWags commented Nov 22, 2021 •
edited

Proposed test cases for this issue:

Figma doc for reference: https://www.figma.com/file/oWF3SKW1KSQxFpSKPskpoh/Brave-Rewards-widget?node-id=42%3A1943.

Scenario 1 - br v2 (normal)

A. Clean profile

  1. Set up clean profile with 1.33.x, enable BR.
  2. Claim UGP grant.
  3. Do one time tip, monthly tip, and AC.
  4. View a couple ads.
  5. Confirm all BAT values, contribution amounts and ad earnings are displayed on the NTP widget appropriately.
  6. Confirm widget UI is as expected per figma.

B. Upgrade profile

  1. Using 1.32.x, set up a profile with contributions made and ads viewed.
  2. Upgrade to 1.33.x.
  3. Confirm all BAT values, contribution amounts and ad earnings are displayed on the NTP widget as per the previous release.
  4. Confirm widget UI is as expected per figma.
  5. View another ad.
  6. Do another tip.
  7. Confirm NTP widget updates appropriately.
Scenario 2 - br v2 (pending)

Note before beginning, the "pending" message has slightly different text than figma. Confirmed with Chris/Kevin this is expected. Wording in this area was generally changed with #17943.

A. Clean profile

  1. Set up clean profile with 1.33.x, enable BR.
  2. View a couple ads, confirm they are cashed in with the server.
  3. Advance computer clock to next month.
  4. Confirm widget shows the appropriate message and BAT value.
  5. Confirm that the "Earning" BAT amount is as expected.
  6. Advance computer clock to date that payout is estimated to begin per message.
  7. Confirm message is no longer shown on the widget.

B. Upgrade profile

  1. Set up profile with 1.32.x, enable BR.
  2. View a couple ads, confirm they are cashed in with the server.
  3. Advance computer clock to next month.
  4. Confirm widget shows the appropriate message and BAT value.
  5. Upgrade to 1.33.x.
  6. Confirm widget shows the appropriate message and BAT value.
  7. Confirm that the "Earning" BAT amount is as expected.
  8. Advance computer clock to date that payout is estimated to begin per message.
  9. Confirm message is no longer shown on the widget.
Scenario 3 - br v2 (arrived kyc'd) - N/A

Confirmed with Kevin that this scenario is not applicable at this time.

Scenario 4 - br v2 (arrived grant)

A. Clean profile 1 - closing ad grant message without claim

  1. Set up clean profile with 1.33.x, enable BR.
  2. Ask Chris to send you an ad grant.
  3. Wait for Ad grant.
  4. Confirm widget shows the appropriate message and BAT value.
  5. Confirm clicking "x" closes the message about ad grant.

B. Clean profile 2 - claiming ad grant from widget

  1. Set up clean profile with 1.33.x, enable BR.
  2. Ask Chris to send you an ad grant.
  3. Wait for Ad grant.
  4. Confirm widget shows the appropriate message and BAT value.
  5. Confirm clicking "Claim Earnings" opens the panel and shows the captcha.
  6. Confirm able to claim the captcha.
  7. Confirm once the ad grant is successfully claimed the message on the widget is closed and does not show on a new tab.

C. Clean profile 3 - multiple ad grants

  1. Set up clean profile with 1.33.x, enable BR.
  2. Ask Chris to send you 2-3 ad grants.
  3. Wait for Ad grant.
  4. Confirm widget shows the appropriate message and BAT value.
  5. Confirm clicking "Claim Earnings" opens the panel and shows the captcha.
  6. Confirm able to claim the captcha.
  7. Confirm once the ad grant is successfully claimed the message on the widget is closed.
  8. Confirm the message for the 2nd ad grant is shown once the first one is closed.

D. Upgrade profile - ad grant

  1. Set up profile with 1.32.x, enable BR.
  2. Ask Chris to send you an ad grant.
  3. Wait for Ad grant.
  4. Upgrade to 1.33.x.
  5. Confirm widget shows the appropriate message and BAT value.
  6. Confirm clicking "Claim Earnings" opens the panel and shows the captcha.
  7. Confirm able to claim the captcha.
  8. Confirm once the ad grant is successfully claimed the message on the widget is closed and does not show on a new tab.

E. Spot check UGP grants

  • Generally confirm message for UGP grant shows on widget.
  • Confirm message can be closed without claiming.
  • Confirm able to claim from the widget (panel opens and shows captcha for claiming UGP grant)
Scenario 5 - br v2 (earn and give)

Note: "proceeding" text instead of "click" is expected, confirmed with Chris/Kevin.

A. Clean profile

  1. Set up clean profile with 1.33.x, do not enable BR.
  2. Confirm widget UI is as expected per figma.
  3. Confirm all links on the widget work as expected.
  4. Confirm able to join rewards from the widget.

B. Upgrade profile

  1. Using 1.32.x, set up a profile and do not enable BR.
  2. Upgrade to 1.33.x.
  3. Confirm widget UI is as expected per figma.
  4. Confirm all links on the widget work as expected.
  5. Confirm able to join rewards from the widget.
Scenario 6 - br v2 (enable ads)

A. Clean profile

  1. Set up clean profile with 1.33.x, enable BR.
  2. Disable Ads.
  3. Confirm widget UI is as expected per figma.
  4. Confirm able to enable ads from widget.
  5. Confirm able to view an ad and get rewarded.

B. Upgrade profile

  1. Using 1.32.x, enable BR. Disable Ads.
  2. Upgrade to 1.33.x.
  3. Confirm widget UI is as expected per figma.
  4. Confirm able to enable ads from widget.
  5. Confirm able to view an ad and get rewarded.
Scenario 7 - Earning tooltip ("i" icon)

Note - text differs slightly from figma, this was changed with #17943 to use the "processing" language.

A. Clean profile

  1. Set up clean profile with 1.33.x, enable BR.
  2. View a couple ads.
  3. Look at the NTP widget.
  4. Confirm the tooltip for the "i" icon is as per figma.
  5. Confirm the correct date is reflected in tooltip text (matches date from ads panel on brave://rewards)
Scenario 8 - NTP SI Tooltip

Note - as with above scenarios, some wording differs slightly from figma. This is expected per discussions.

A. Clean profile 1

  1. Set up clean profile with 1.33.x, do not enable BR.
  2. Open the NTP until you get an NTP SI.
  3. Confirm you see the tooltip over the NTP SI logo/text in lower right corner of the browser.
  4. Close the NTP with the SI quickly (do not have it open for longer than ~2-3s, if it is open for longer than this restart the test).
  5. Open NTPs until you get the NTP SI again.
  6. Confirm that the tooltip is shown again (it shows on each NTP SI until it has been displayed for ~4s per Kevin).
  7. Confirm tooltip UI is as expected per figma ("ads off" tooltip text).
  8. Confirm all links on the tooltip work as expected.
  9. Confirm able to close the tooltip with the "x".
  10. Open the NTP until you get an NTP SI.
  11. Confirm tooltip is not shown again.

B. Clean profile 2

  1. Start another profile, do not enable BR.
  2. Open the NTP until you get an NTP SI.
  3. Leave page open for at least 5s.
  4. Close NTP SI page.
  5. Open NTPs until you get the NTP SI again.
  6. Confirm tooltip is not shown again.

C. Clean profile 3

  1. Start another profile, do not enable BR.
  2. Open the NTP until you get an NTP SI.
  3. Confirm able to join Rewards from the tooltip.
  4. Watch logs to confirm all calls/services start as expected.
  5. Confirm tooltip UI is as expected per figma ("ads on" tooltip text).
  6. Open NTPs until you get to another NTP SI.
  7. Confirm you are rewarded for this NTP SI view (might take a few seconds to update).
  8. Confirm tooltip UI is as expected per figma ("ads on" tooltip text)
  9. Close/restart the browser.
  10. Open the NTP until you get an NTP SI.
  11. Confirm no tooltip text.

D. Clean profile 4

  1. Start another profile, enable BR. Confirm all services/calls as expected.
  2. Open the NTP until you get an NTP SI.
  3. Confirm tooltip UI is displayed
  4. Confirm you are rewarded for this NTP SI view (might take a few seconds to update).
  5. Close the tooltip using the "x".
  6. Open the NTP until you get an NTP SI.
  7. Confirm no tooltip text shown over NTP SI logo/text.
  8. Close/restart the browser.
  9. Open the NTP until you get an NTP SI.
  10. Confirm no tooltip text.

E. Clean profile 5

  1. Start another profile, do not enable BR.
  2. Open NTP (it should not be NTP SI)
  3. Remove Rewards widget from view
  4. Open the NTP until you get an NTP SI.
  5. Confirm the tooltip prompting you to join Rewards is shown even though the Rewards widget is not visible.
  6. Confirm able to join Rewards from the tooltip.
  7. Watch logs to confirm all calls/services start as expected.
  8. Open NTPs until you get to the NTP SI.
  9. Confirm you are rewarded for this NTP SI view (might take a few seconds to update).
  10. Confirm that the tooltip which shows that you are being rewarded is displayed even though the Rewards widget is not visible.

F. Upgrade profile 1

  1. Using 1.32.x, View an NTP SI for at least 5s (there is no tooltip, but there is a dismissible notification on the widget).
  2. Upgrade to 1.33.x.
  3. Open NTPs until you get to the NTP SI.
  4. Confirm tooltip is not shown on upgraded profile.

G. Upgrade profile 2

  1. Using 1.32.x, Enable Rewards.
  2. View an NTP SI.
  3. Confirm you are rewarded for it (there is no tooltip, but there is a dismissible notification on the widget).
  4. Upgrade to 1.33.x.
  5. Open NTPs until you get to the NTP SI.
  6. Confirm tooltip is not shown on upgraded profile.
Scenario 9 - Translations

Spot check translations on the widget in several languages.

@LaurenWags LaurenWags mentioned this issue Nov 23, 2021
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Nov 23, 2021 •
edited by stephendonner

Verified using

Brave	1.33.87 Chromium: 96.0.4664.45 (Official Build) beta (x86_64)
Revision	76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS	macOS Version 11.6.1 (Build 20G224)

Verified various UI states from https://www.figma.com/file/oWF3SKW1KSQxFpSKPskpoh/Brave-Rewards-widget?node-id=42%3A1943.

Logged #19691.

Scenario 1 - br v2 (normal) - PASSED

A. Clean profile

  1. Set up clean profile with 1.33.x, enable BR.
  2. Claim UGP grant.
  3. Do one time tip, monthly tip, and AC.
  4. View a couple ads.
  5. Confirm all BAT values, contribution amounts and ad earnings are displayed on the NTP widget appropriately.
  6. Confirm widget UI is as expected per figma.

Confirmed Balance, Earning and Giving amounts were as expected per the panel and brave://rewards page.
Confirmed widget UI is as expected per figma.

Example Example Example
1A1 1A2 1A3

B. Upgrade profile

  1. Using 1.32.x, set up a profile with contributions made and ads viewed.
  2. Upgrade to 1.33.x.
  3. Confirm all BAT values, contribution amounts and ad earnings are displayed on the NTP widget as per the previous release.
  4. Confirm widget UI is as expected per figma.
  5. View another ad.
  6. Do another tip.
  7. Confirm NTP widget updates appropriately.

Confirmed Balance, Earning and Giving amounts were as expected per the previous version.
Confirmed widget UI is as expected per figma.
Confirmed able to view another ad/do another tip and widget updates as expected.

Example Example Example
1B1 1B2 1B3
Scenario 2 - br v2 (pending) - PASSED

A. Clean profile

  1. Set up clean profile with 1.33.x, enable BR.
  2. View a couple ads, confirm they are cashed in with the server.
  3. Advance computer clock to next month.
  4. Confirm widget shows the appropriate message and BAT value.
  5. Confirm that the "Earning" BAT amount is as expected.
  6. Advance computer clock to date that payout is estimated to begin per message.
  7. Confirm message is no longer shown on the widget.

Confirmed "pending" messaging was displayed on widget (note, different text than figma. Confirmed with Chris/Kevin this is expected. Wording in this area was generally changed with #17943).
Confirmed messaging on widget matched ad panel on brave://rewards.
Confirmed on date that payouts are to begin (Dec 7), the "pending" messaging is no longer displayed on the widget.

Dec 1 Widget Dec 1 Ad panel Dec 7 Widget
2A1 2A2 2A3

B. Upgrade profile

  1. Set up profile with 1.32.x, enable BR.
  2. View a couple ads, confirm they are cashed in with the server.
  3. Advance computer clock to next month.
  4. Confirm widget shows the appropriate message and BAT value.
  5. Upgrade to 1.33.x.
  6. Confirm widget shows the appropriate message and BAT value.
  7. Confirm that the "Earning" BAT amount is as expected.
  8. Advance computer clock to date that payout is estimated to begin per message.
  9. Confirm message is no longer shown on the widget.

Confirmed "pending" messaging was displayed on widget (note, different text than figma as per above).
Confirmed messaging on widget matched ad panel on brave://rewards.
Confirmed on date that payouts are to begin (Dec 7), the "pending" messaging is no longer displayed on the widget.

Dec 1 Widget 1.32.x Dec 1 Widget 1.33.x Dec 7 Widget 1.33.x
2B1 2B2 2B3
Scenario 3 - br v2 (arrived kyc'd) - N/A

Confirmed with Kevin that this scenario is not applicable at this time.

Scenario 5 - br v2 (earn and give) - PASSED

A. Clean profile

  1. Set up clean profile with 1.33.x, do not enable BR.
  2. Confirm widget UI is as expected per figma.
  3. Confirm all links on the widget work as expected.
  4. Confirm able to join rewards from the widget.

Confirmed "Terms of Service" link directs to https://basicattentiontoken.org/user-terms-of-service/.
Confirmed "Privacy Policy" link directs to https://brave.com/privacy/browser/#rewards.
Confirmed UI is as expected per figma ("proceeding" instead of "click" wording is expected per Chris/Kevin).
Confirmed clicking "Start using Rewards" enables Rewards (Ads, Auto Contribute).

Example Example
5A1 5A2

B. Upgrade profile

  1. Using 1.32.x, set up a profile and do not enable BR.
  2. Upgrade to 1.33.x.
  3. Confirm widget UI is as expected per figma.
  4. Confirm all links on the widget work as expected.
  5. Confirm able to join rewards from the widget.

Confirmed "Terms of Service" link directs to https://basicattentiontoken.org/user-terms-of-service/.
Confirmed "Privacy Policy" link directs to https://brave.com/privacy/browser/#rewards.
Confirmed UI is as expected per figma ("proceeding" instead of "click" wording is expected per Chris/Kevin).
Confirmed clicking "Start using Rewards" enables Rewards (Ads, Auto Contribute).

1.32.x Widget 1.33.x Widget
5B1 5B2 
Brave | 1.33.93 Chromium: 96.0.4664.45 (Official Build) beta (x86_64)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | macOS Version 11.6.1 (Build 20G224)
Scenario 6 - br v2 (enable ads) - PASSED

A. Clean profile

  1. Set up clean profile with 1.33.x, enable BR.
  2. Disable Ads.
  3. Confirm widget UI is as expected per figma.
  4. Confirm able to enable ads from widget.
  5. Confirm able to view an ad and get rewarded.

Confirmed UI was as per figma.
Confirmed "Rewards Settings" link opens brave://rewards page.
Confirmed clicking "Start using Rewards" enables Ads.
Confirmed able to view an ad and be rewarded.

Example Example Example
6A1 6A2 6A3

B. Upgrade profile

  1. Using 1.32.x, enable BR. Disable Ads.
  2. Upgrade to 1.33.x.
  3. Confirm widget UI is as expected per figma.
  4. Confirm able to enable ads from widget.
  5. Confirm able to view an ad and get rewarded.

Confirmed UI was as per figma.
Confirmed "Rewards Settings" link opens brave://rewards page.
Confirmed clicking "Start using Rewards" enables Ads.
Confirmed able to view an ad and be rewarded.

Example Example Example
6B1 6B2 6B3
Scenario 7 - Earning tooltip ("i" icon) - PASSED

A. Clean profile

  1. Set up clean profile with 1.33.x, enable BR.
  2. View a couple ads.
  3. Look at the NTP widget.
  4. Confirm the tooltip for the "i" icon is as per figma.
  5. Confirm the correct date is reflected in tooltip text (matches date from ads panel on brave://rewards)

Note - text differs slightly from figma, this was changed with #17943 to use the "processing" language.

Confirmed UI was as per figma.
Confirmed date on tooltip matches ads panel on brave://rewards.

Example Example
7A1 7A2
Scenario 8 - NTP SI Tooltip - PASSED

A. Clean profile 1

  1. Set up clean profile with 1.33.x, do not enable BR.
  2. Open the NTP until you get an NTP SI.
  3. Confirm you see the tooltip over the NTP SI logo/text in lower right corner of the browser.
  4. Close the NTP with the SI quickly (do not have it open for longer than ~2-3s, if it is open for longer than this restart the test).
  5. Open NTPs until you get the NTP SI again.
  6. Confirm that the tooltip is shown again (it shows on each NTP SI until it has been displayed for ~4s per Kevin).
  7. Confirm tooltip UI is as expected per figma ("ads off" tooltip text).
  8. Confirm all links on the tooltip work as expected.
  9. Confirm able to close the tooltip with the "x".
  10. Open the NTP until you get an NTP SI.
  11. Confirm tooltip is not shown again.

Confirmed "Terms of Service" link directs to https://basicattentiontoken.org/user-terms-of-service/.
Confirmed "Privacy Policy" link directs to https://brave.com/privacy/browser/#rewards.
Confirmed UI is as expected per figma ("proceeding" instead of "click" wording is expected).
Confirmed tooltip showed as expected.
Confirmed tooltip was not shown after dismissing via the "x".

8A1

B. Clean profile 2

  1. Start another profile, do not enable BR.
  2. Open the NTP until you get an NTP SI.
  3. Leave page open for at least 5s.
  4. Close NTP SI page.
  5. Open NTPs until you get the NTP SI again.
  6. Confirm tooltip is not shown again.

Confirmed NTP SI tooltip was not shown on subsequent NTP SI pages once it had been visible for ~5s.

C. Clean profile 3

  1. Start another profile, do not enable BR.
  2. Open the NTP until you get an NTP SI.
  3. Confirm able to join Rewards from the tooltip.
  4. Watch logs to confirm all calls/services start as expected.
  5. Confirm tooltip UI is as expected per figma ("ads on" tooltip text).
  6. Open NTPs until you get to another NTP SI.
  7. Confirm you are rewarded for this NTP SI view (might take a few seconds to update).
  8. Confirm tooltip UI is as expected per figma ("ads on" tooltip text).
  9. Close/restart the browser.
  10. Open the NTP until you get an NTP SI.
  11. Confirm no tooltip text.

Confirmed UI was as per figma.
Confirmed "Learn more" linked to https://brave.com/brave-rewards/.

7C1

D. Clean profile 4

  1. Start another profile, enable BR. Confirm all services/calls as expected.
  2. Open the NTP until you get an NTP SI.
  3. Confirm tooltip UI is displayed
  4. Confirm you are rewarded for this NTP SI view (might take a few seconds to update).
  5. Close the tooltip using the "x".
  6. Open the NTP until you get an NTP SI.
  7. Confirm no tooltip text shown over NTP SI logo/text.
  8. Close/restart the browser.
  9. Open the NTP until you get an NTP SI.
  10. Confirm no tooltip text.

Confirmed tooltip was displayed in step where expected.
Confirmed tooltip was not displayed in steps where it was not expected.
Confirmed I was rewarded for NTP SI views as expected.

E. Clean profile 5

  1. Start another profile, do not enable BR.
  2. Open NTP (it should not be NTP SI)
  3. Remove Rewards widget from view
  4. Open the NTP until you get an NTP SI.
  5. Confirm the tooltip prompting you to join Rewards is shown even though the Rewards widget is not visible.
  6. Confirm able to join Rewards from the tooltip.
  7. Watch logs to confirm all calls/services start as expected.
  8. Open NTPs until you get to the NTP SI.
  9. Confirm you are rewarded for this NTP SI view (might take a few seconds to update).
  10. Confirm that the tooltip which shows that you are being rewarded is displayed even though the Rewards widget is not visible.

Confirmed tooltips were shown independent of the widget.
Confirmed via the panel I was rewarded for NTP SI view.

F. Upgrade profile 1

  1. Using 1.32.x, View an NTP SI for at least 5s (there is no tooltip, but there is a dismissible notification on the widget).
  2. Upgrade to 1.33.x.
  3. Open NTPs until you get to the NTP SI.
  4. Confirm tooltip is not shown on upgraded profile.

Confirmed no tooltip on upgraded profile when the previous message had been displayed on earlier version.

G. Upgrade profile 2

  1. Using 1.32.x, Enable Rewards.
  2. View an NTP SI.
  3. Confirm you are rewarded for it (there is no tooltip, but there is a dismissible notification on the widget).
  4. Upgrade to 1.33.x.
  5. Open NTPs until you get to the NTP SI.
  6. Confirm tooltip is not shown on upgraded profile.

Confirmed no tooltip on upgraded profile when the previous message had been displayed on earlier version.
Encountered known issue #13815.

Scenario 4 - br v2 (arrived grant) - PASSED

A. Clean profile 1 - closing ad grant message without claim

  1. Set up clean profile with 1.33.x, enable BR.
  2. Ask Chris to send you an ad grant.
  3. Wait for Ad grant.
  4. Confirm widget shows the appropriate message and BAT value.
  5. Confirm clicking "x" closes the message about ad grant.

Confirmed widget showed appropriate message per figma.
Confirmed widget message displayed BAT value.
Confirmed clicking the "x" closed the message as expected.
Confirmed refreshing the page, opening new tabs, and close/relaunch of browser did not make the message appear again.

Example before clicking "x" Example after clicking "x"
4A1 4A2

B. Clean profile 2 - claiming ad grant from widget

  1. Set up clean profile with 1.33.x, enable BR.
  2. Ask Chris to send you an ad grant.
  3. Wait for Ad grant.
  4. Confirm widget shows the appropriate message and BAT value.
  5. Confirm clicking "Claim Earnings" opens the panel and shows the captcha.
  6. Confirm able to claim the captcha.
  7. Confirm once the ad grant is successfully claimed the message on the widget is closed and does not show on a new tab.

Confirmed widget showed appropriate message per figma.
Confirmed widget message displayed BAT value.
Confirmed clicking "Claim earnings" opened the panel w/ the captcha to claim the grant.
Confirmed able to successfully claim the ad grant.
Confirmed the widget updated with the ad earnings once claimed (took a bit of time as expected).
Confirmed refreshing the page, opening new tabs, and close/relaunch of browser did not make the message appear again.

Example Example Example
Screen Shot 2021-11-30 at 10 38 28 AM Screen Shot 2021-11-30 at 10 38 59 AM Screen Shot 2021-11-30 at 10 39 27 AM

C. Clean profile 3 - multiple ad grants

  1. Set up clean profile with 1.33.x, enable BR.
  2. Ask Chris to send you 2-3 ad grants.
  3. Wait for Ad grant.
  4. Confirm widget shows the appropriate message and BAT value.
  5. Confirm clicking "Claim Earnings" opens the panel and shows the captcha.
  6. Confirm able to claim the captcha.
  7. Confirm once the ad grant is successfully claimed the message on the widget is closed.
  8. Confirm the message for the 2nd ad grant is shown once the first one is closed.

Confirmed multiple ad grant messages can be handled on the widget.

Example Example Example Example Example Example Example
Screen Shot 2021-11-30 at 10 53 27 AM Screen Shot 2021-11-30 at 10 53 48 AM Screen Shot 2021-11-30 at 10 54 03 AM Screen Shot 2021-11-30 at 10 54 15 AM Screen Shot 2021-11-30 at 10 54 25 AM Screen Shot 2021-11-30 at 10 54 42 AM Screen Shot 2021-11-30 at 10 54 59 AM

D. Upgrade profile - ad grant

  1. Set up profile with 1.32.x, enable BR.
  2. Ask Chris to send you an ad grant.
  3. Wait for Ad grant.
  4. Upgrade to 1.33.x.
  5. Confirm widget shows the appropriate message and BAT value.
  6. Confirm clicking "Claim Earnings" opens the panel and shows the captcha.
  7. Confirm able to claim the captcha.
  8. Confirm once the ad grant is successfully claimed the message on the widget is closed and does not show on a new tab.

Confirmed widget showed appropriate message per figma.
Widget message did not display BAT value after upgrade. Logged #19833.
Confirmed clicking "Claim earnings" opened the panel w/ the captcha to claim the grant.
Confirmed able to successfully claim the ad grant.
Confirmed the widget updated with the ad earnings once claimed (took a bit of time as expected).
Confirmed refreshing the page, opening new tabs, and close/relaunch of browser did not make the message appear again.

1.32.x widget message 1.33.x widget message Example Example
Screen Shot 2021-11-30 at 11 23 04 AM Screen Shot 2021-11-30 at 11 23 59 AM Screen Shot 2021-11-30 at 11 24 20 AM Screen Shot 2021-11-30 at 11 24 28 AM

E. Spot check UGP grants

  • Generally confirm message for UGP grant shows on widget.
  • Confirm message can be closed without claiming.
  • Confirm able to claim from the widget (panel opens and shows captcha for claiming UGP grant)

Confirmed the above work as expected.

Screen Shot 2021-11-30 at 11 49 25 AM
Scenario 9 - Translations - PASSED

Spot check translations on the widget in several languages.

Polish

NTP SI Tooltip NTP SI Tooltip Default widget All Rewards enabled Ads disabled UGP Grant Ad Grant Pending Ads "i" tooltip
Polish NTP SI tooltip 1 Polish NTP SI tooltip 2 Polish default Polish all enabled Polish ads disabled Polish UGP grant Polish ad grant polish pending polish i

French

NTP SI Tooltip NTP SI Tooltip Default widget All Rewards enabled Ads disabled UGP Grant Ad Grant Pending Ads "i" tooltip
french ntp tooltip 1 french tooltip 2 french default french all enabled french ads off french ugp grant french ad grant French pending ads french i

Verification passed on

Brave | 1.33.94 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | Windows 10 Version 21H2 (Build 19044.1387)
Scenario 1 - br v2 (normal) - PASSED

A. Clean profile

  1. Set up clean profile with 1.33.x, enable BR.
  2. Claim UGP grant.
  3. Do one time tip, monthly tip, and AC.
  4. View a couple ads.
  5. Confirm all BAT values, contribution amounts and ad earnings are displayed on the NTP widget appropriately.
  6. Confirm widget UI is as expected per figma.

Confirmed Balance, Earning and Giving amounts were as expected per the panel and brave://rewards page.
Confirmed widget UI is as expected per figma.

Example Example Example
image image image

B. Upgrade profile

  1. Using 1.32.x, set up a profile with contributions made and ads viewed.
  2. Upgrade to 1.33.x.
  3. Confirm all BAT values, contribution amounts and ad earnings are displayed on the NTP widget as per the previous release.
  4. Confirm widget UI is as expected per figma.
  5. View another ad.
  6. Do another tip.
  7. Confirm NTP widget updates appropriately.

Confirmed Balance, Earning and Giving amounts were as expected per the previous version.
Confirmed widget UI is as expected per figma.
Confirmed able to view another ad/do another tip and widget updates as expected.

Example Example Example
image image image
Scenario 2 - br v2 (pending) - PASSED

A. Clean profile

  1. Set up clean profile with 1.33.x, enable BR.
  2. View a couple ads, confirm they are cashed in with the server.
  3. Advance computer clock to next month.
  4. Confirm widget shows the appropriate message and BAT value.
  5. Confirm that the "Earning" BAT amount is as expected.
  6. Advance computer clock to date that payout is estimated to begin per message.
  7. Confirm message is no longer shown on the widget.

Confirmed "pending" messaging was displayed on widget (note, different text than figma. Confirmed with Chris/Kevin this is expected. Wording in this area was generally changed with #17943).
Confirmed messaging on widget matched ad panel on brave://rewards.
Confirmed on date that payouts are to begin (Dec 7), the "pending" messaging is no longer displayed on the widget.

Jan 1 Widget Jan 1 Ad panel Jan 7 Widget
image image image
Scenario 4: br v2 (arrived grant) - PASSED

B. Clean profile 2 - claiming ad grant from widget

  1. Set up clean profile with 1.33.x, enable BR.
  2. Ask Chris to send you an ad grant.
  3. Wait for Ad grant.
  4. Confirm widget shows the appropriate message and BAT value.
  5. Confirm clicking "Claim Earnings" opens the panel and shows the captcha.
  6. Confirm able to claim the captcha.
  7. Confirm once the ad grant is successfully claimed the message on the widget is closed and does not show on a new tab.

Confirmed widget showed appropriate message per figma.
Confirmed widget message displayed BAT value.
Confirmed clicking "Claim earnings" opened the panel w/ the captcha to claim the grant
Confirmed able to successfully claim the ad grant.
Confirmed the widget updated with the ad earnings once claimed (took a bit of time as expected).
Confirmed refreshing the page, opening new tabs, and close/relaunch of browser did not make the message appear again.

Example Example Example
image image image

(Claimed two grants(5 BAT and 3 BAT) as @Miyayes sent two ad grants. hence balance 8 BAT is shown in the NTP widget

Scenario 5 - br v2 (earn and give) - PASSED

A. Clean profile

  1. Set up clean profile with 1.33.x, do not enable BR.
  2. Confirm widget UI is as expected per figma.
  3. Confirm all links on the widget work as expected.
  4. Confirm able to join rewards from the widget.

Confirmed "Terms of Service" link directs to https://basicattentiontoken.org/user-terms-of-service/.
Confirmed "Privacy Policy" link directs to https://brave.com/privacy/browser/#rewards.
Confirmed UI is as expected per figma ("proceeding" instead of "click" wording is expected per Chris/Kevin).
Confirmed clicking "Start using Rewards" enables Rewards (Ads, Auto Contribute).

Example Example
image image
Scenario 6 - br v2 (enable ads) - PASSED

A. Clean profile

  1. Set up clean profile with 1.33.x, enable BR.
  2. Disable Ads.
  3. Confirm widget UI is as expected per figma.
  4. Confirm able to enable ads from widget.
  5. Confirm able to view an ad and get rewarded.

Confirmed UI was as per figma.
Confirmed "Rewards Settings" link opens brave://rewards page.
Confirmed clicking "Start using Rewards" enables Ads.
Confirmed able to view an ad and be rewarded.

Example Example Example
image image image
Scenario 7 - Earning tooltip ("i" icon) - PASSED

A. Clean profile

  1. Set up clean profile with 1.33.x, enable BR.
  2. View a couple ads.
  3. Look at the NTP widget.
  4. Confirm the tooltip for the "i" icon is as per figma.
  5. Confirm the correct date is reflected in tooltip text (matches date from ads panel on brave://rewards)

Note - text differs slightly from figma, this was changed with #17943 to use the "processing" language.

Confirmed UI was as per figma.
Confirmed date on tooltip matches ads panel on brave://rewards.

Example Example
image image
Scenario 8 - NTP SI Tooltip - PASSED

B. Clean profile 2

  1. Start another profile, do not enable BR.
  2. Open the NTP until you get an NTP SI.
  3. Leave page open for at least 5s.
  4. Close NTP SI page.
  5. Open NTPs until you get the NTP SI again.
  6. Confirm tooltip is not shown again.

Confirmed NTP SI tooltip was not shown on subsequent NTP SI pages once it had been visible for ~5s.

C. Clean profile 3

  1. Start another profile, do not enable BR.
  2. Open the NTP until you get an NTP SI.
  3. Confirm able to join Rewards from the tooltip.
  4. Watch logs to confirm all calls/services start as expected.
  5. Confirm tooltip UI is as expected per figma ("ads on" tooltip text).
  6. Open NTPs until you get to another NTP SI.
  7. Confirm you are rewarded for this NTP SI view (might take a few seconds to update).
  8. Confirm tooltip UI is as expected per figma ("ads on" tooltip text).
  9. Close/restart the browser.
  10. Open the NTP until you get an NTP SI.
  11. Confirm no tooltip text.

Confirmed UI was as per figma.
Confirmed "Learn more" linked to https://brave.com/brave-rewards/.

E. Clean profile 5

  1. Start another profile, do not enable BR.
  2. Open NTP (it should not be NTP SI)
  3. Remove Rewards widget from view
  4. Open the NTP until you get an NTP SI.
  5. Confirm the tooltip prompting you to join Rewards is shown even though the Rewards widget is not visible.
  6. Confirm able to join Rewards from the tooltip.
  7. Watch logs to confirm all calls/services start as expected.
  8. Open NTPs until you get to the NTP SI.
  9. Confirm you are rewarded for this NTP SI view (might take a few seconds to update).
  10. Confirm that the tooltip which shows that you are being rewarded is displayed even though the Rewards widget is not visible.

Confirmed tooltips were shown independent of the widget.
Confirmed via the panel I was rewarded for NTP SI view.

F. Upgrade profile 1

  1. Using 1.32.x, View an NTP SI for at least 5s (there is no tooltip, but there is a dismissible notification on the widget).
  2. Upgrade to 1.33.x.
  3. Open NTPs until you get to the NTP SI.
  4. Confirm tooltip is not shown on upgraded profile.

Confirmed no tooltip on upgraded profile when the previous message had been displayed on earlier version.

G. Upgrade profile 2

  1. Using 1.32.x, Enable Rewards.
  2. View an NTP SI.
  3. Confirm you are rewarded for it (there is no tooltip, but there is a dismissible notification on the widget).
  4. Upgrade to 1.33.x.
  5. Open NTPs until you get to the NTP SI.
  6. Confirm tooltip is not shown on upgraded profile.

Confirmed no tooltip on upgraded profile when the previous message had been displayed on earlier version.
Encountered known issue #13815.

Verified PASSED using

Brave 1.33.95 Chromium: 96.0.4664.45 (Official Build) dev (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

As discussed in Slack, for Linux, I spot-checked against a few various states in Figma: https://www.figma.com/file/oWF3SKW1KSQxFpSKPskpoh/Brave-Rewards-widget?node-id=42%3A1943

example example example example example example example example
Screen Shot 2021-11-30 at 3 57 37 PM Screen Shot 2021-11-30 at 4 02 26 PM Screen Shot 2021-12-01 at 7 46 38 AM Screen Shot 2021-12-01 at 7 48 39 AM Screen Shot 2021-12-01 at 7 51 06 AM Screen Shot 2021-12-01 at 8 57 00 AM Screen Shot 2021-12-01 at 8 57 16 AM Screen Shot 2021-12-01 at 8 57 18 AM

@LaurenWags LaurenWags mentioned this issue Nov 30, 2021
Closed
@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 30, 2021
@LaurenWags LaurenWags mentioned this issue Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards feature/widgets OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Brave Rewards
  
Done
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Update new tab page rewards widget brave/brave-core
5 participants
@stephendonner @zenparsing @Miyayes @LaurenWags @GeetaSarvadnya