websites not being added into auto-contribution table after contribution as been made

[kjozwiak]

Description

After you've contributed, you'll notice that the attention you've spent on the first website you load after the contribution isn't being calculated correctly. I've managed to reproduce this several times and also showed @NejcZdovc via Zoom.

After spending about 20-30s on a website, publisher_info_db showed three seconds.

Steps to Reproduce

1. launch brave using /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --rewards-reconcile-interval=4
2. once launched, quickly enable rewards via brave://rewards
3. visit several websites and populate the auto-contribution table before four minutes
4. ~4 mins, you should see the auto-contribution table clear
5. open a new tab and visit a new site for about 30-40s
6. switch back to the chrome://rewards tab and you won't see the above entry in the table

If you take a look at publisher_info_db, you'll notice that the incorrect time was calculated.

Actual result:

https://drive.google.com/file/d/1OCKmHmQ7G444xWqso33U2aW7xSUiesgX/view?usp=sharing

Expected result:

Websites should be added into the auto-contribution table once they've reached the set Minimum page time before logging a visit

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave	0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS	Mac OS X

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?

Haven't tried but assuming this is also in both dev and beta.

Additional Information

CCing @jenn-rhim @mandar-brave this is what I was talking about re: websites not being added correctly after a contribution has been made.

[NejcZdovc]

@kjozwiak can't reproduce this on master anymore, let's test it out on RC for hotfix 2

[kjozwiak]

@NejcZdovc sure, once we get an RC for hotfix 2, I'll go through this again and see if it's reproducible. Do we have any idea's when we'll have on available? I think the original plan was Thursday night.

[NejcZdovc]

@kjozwiak yeah we are still on that plan

[kjozwiak]

Looks like this is working on macOS 10.13.6 x64 using the following build:

Brave	0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS	Mac OS X

QA will double check once we get the RC builds just to make sure this has been resolved.

Verification Passed on

Brave	0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS	Linux

• Will verify again with RC build

Verification Passed on

Brave	0.55.21 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Windows

[NejcZdovc]

closing as looks like it was fixed

[LaurenWags]

Verified passed with

Brave	0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Mac OS X

• Verified STR from description (used Staging environment)

Verification Passed on

Brave	0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Linux