Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default wallet setting for Android #18325

Closed
bbondy opened this issue Sep 23, 2021 · 1 comment · Fixed by brave/brave-core#21340
Closed

Add default wallet setting for Android #18325

bbondy opened this issue Sep 23, 2021 · 1 comment · Fixed by brave/brave-core#21340
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.63.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Sep 23, 2021

from brave_wallet_utils.h you can get/set the default wallet:
brave/brave-core#10236

We should only support Brave Wallet and None on Android. Default being Brave Wallet.

This will disable the dapp detection, but we might also want it for other functionality in the future.
@bbondy bbondy added the OS/Android Fixes related to Android browser functionality label Sep 23, 2021
@bbondy bbondy added this to Untriaged in Wallet via automation Sep 23, 2021
@bbondy bbondy moved this from Untriaged to Backlog (MVP) in Wallet Sep 23, 2021
@bbondy bbondy moved this from Backlog (MVP) to Backlog (MVP, mobile only) in Wallet Oct 7, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Oct 18, 2021
@SergeyZhukovsky SergeyZhukovsky added QA/No release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 22, 2021
@bbondy bbondy moved this from Mobile MVP Backlog to Backlog in Wallet Dec 2, 2021
@bbondy bbondy moved this from Backlog to Untriaged in Wallet Dec 3, 2021
@bbondy bbondy moved this from Untriaged to Backlog in Wallet Dec 3, 2021
@bbondy bbondy moved this from Backlog to Backlog (Android) in Wallet Dec 4, 2021
@SergeyZhukovsky SergeyZhukovsky removed their assignment Dec 17, 2021
@bbondy bbondy removed this from Backlog (Android) in Wallet Mar 17, 2022
@simoarpe simoarpe self-assigned this Oct 12, 2023
@simoarpe simoarpe mentioned this issue Dec 12, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Dec 14, 2023
@srirambv
Copy link
Contributor

Verification passed on Google Pixel 8 with Android 14 running 1.63.157 x64 build

  • Verified steps from brave/brave-core#21340
  • Verified new settings for Default Ethereum Wallet and Default Solana Wallet is available
  • Verified default value is set to Brave Wallet for both setting
  • Verified setting Default Ethereum Wallet set to None, doesn't recognise Brave Wallet on Dapps
  • Verified setting Default Solana Wallet set to None, doesn't recognise Brave Wallet on Dapps
18325.mp4

@kjozwiak kjozwiak mentioned this issue Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.63.x - Release
6 participants
@bbondy @simoarpe @SergeyZhukovsky @srirambv @brave-builds and others