Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show MM/crypto wallets import flow when the user has actually created a wallet on MM/crypto wallets #18534

Closed
srirambv opened this issue Oct 4, 2021 · 2 comments · Fixed by brave/brave-core#11354
Assignees
Projects

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 4, 2021

Description

Current flow detects installation of MM and prompts to import on the new wallet screen. This fails as there is nothing to import so seems unnecessary to show the Import from MM button and the importer page

Steps to Reproduce

  1. Install MM from Web Store (do not create an account)
  2. Enable flag and enable wallet
  3. Wallet page shows Import from MM even when there is nothing to import from

Actual result:

Wallet page shows Import from MM even when there is nothing to import from

Expected result:

Only show MM import button when the user has actually created a wallet on MM

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.38 Chromium: 94.0.4606.71 (Official Build) nightly (x86_64)
Revision 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@darkdh @jamesmudgett

@srirambv srirambv added this to Untriaged in Wallet via automation Oct 4, 2021
@bbondy bbondy moved this from Untriaged to Backlog in Wallet Oct 7, 2021
@darkdh darkdh self-assigned this Oct 22, 2021
@bbondy bbondy added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 29, 2021
@bbondy bbondy moved this from Backlog to Needs more info in Wallet Nov 3, 2021
@bbondy bbondy moved this from Needs more info to Backlog in Wallet Nov 3, 2021
@darkdh
Copy link
Member

darkdh commented Nov 19, 2021

This should also applies to crypto wallets.
Don't show import flow when we detect crypto wallets is not setup

@darkdh darkdh changed the title Only show MM import button when the user has actually created a wallet on MM Only show MM/crypto wallets import flow when the user has actually created a wallet on MM/crypto wallets Nov 19, 2021
@darkdh darkdh moved this from Backlog to In progress in Wallet Nov 23, 2021
@darkdh darkdh added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 23, 2021
@darkdh darkdh moved this from In progress to In Review in Wallet Dec 1, 2021
Wallet automation moved this from In Review to Closed Dec 2, 2021
@darkdh darkdh added this to the 1.35.x - Nightly milestone Dec 2, 2021
@srirambv
Copy link
Contributor Author

Brave 1.35.98 Chromium: 98.0.4758.72 (Official Build) (64-bit)
Revision d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11354
  • Verified when CW Extension is installed, no importer is shown
  • Verified when CW Extension is installed and wallet is created, importer is shown during onboarding
  • Encountered #20799
18534-Linux.mp4
18534-Windows.mp4
18534-macOS.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Wallet
Closed
Development

Successfully merging a pull request may close this issue.

3 participants