Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selecting SE from on-boarding doesn't select the correct SE #18777

Closed
kjozwiak opened this issue Oct 14, 2021 · 1 comment · Fixed by brave/brave-core#10691
Closed

selecting SE from on-boarding doesn't select the correct SE #18777

kjozwiak opened this issue Oct 14, 2021 · 1 comment · Fixed by brave/brave-core#10691
Assignees
Labels
bug feature/search OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@kjozwiak
Copy link
Member

Description

Launch Brave with a locale that has the SE on-boarding modal enabled and you'll notice that both the Standard & Private SE's are not what was selected from on-boarding. I reproduced the issue with both the Spain & Poland locales.

It appears like the selection from the list is incorrectly mapped and another SE is being selected.

Steps to reproduce

Prerequisite: ensure that you're using a locale that still has the SE on-boarding enabled. I used Spain & Poland

  1. launch 1.32.66 Chromium: 95.0.4638.40 (used Poland as the locale for this case)
  2. skip through all the initial on-boarding and tap on the URL
  3. select Qwant as the default SE via the on-boarding modal
  4. DDG is set as the default SE for both Standard & Private windows/tabs

Actual result

DDG is being selected as the default SE rather than the selected Qwant

Expected result

Users selected SE should be set as the default for both Standard & Private

Issue reproduces how often

100% reproducible using the above STR.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): *ARM`
  • Device type (Phone, Tablet, Phablet): Samsung S10+
  • Android version: Android 11

Brave version

  • 1.32.66 Chromium: 95.0.4638.40 - Reproduced
  • 1.30.89 Chromium: 94.0.4606.81 - Reproduced

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @bsclifton @rebron @brave/legacy_qa

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 11 running 1.31.88 x64 build

  • Verified steps from issue description
  • Verified selected SE from onboarding is set as default for both normal and private tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/search OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.

5 participants