Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support allow-until-restart option of per-origin noscript settings #188

Open
yrliou opened this issue May 8, 2018 · 0 comments
Open

Support allow-until-restart option of per-origin noscript settings #188

yrliou opened this issue May 8, 2018 · 0 comments
Assignees
@karenkliu
Labels
browser-laptop-parity feature/shields/!scripts Blocking JavaScript with Shields feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon".

Comments

@yrliou
Copy link
Member

yrliou commented May 8, 2018 •
edited by bsclifton
Loading

Support global per-origin noscript settings which will be cleared until browser restart.

This functionality exists in browser-laptop (Muon) because noscript exposes it like so:
screen shot 2018-10-29 at 3 21 28 pm

The current implementation in brave-core (the Apply button) is the same as hitting Allow this time (ex: there is no Allow until restart option)
@yrliou yrliou added the feature/shields The overall Shields feature in Brave. label May 8, 2018
@yrliou yrliou self-assigned this May 8, 2018
@bbondy bbondy added this to the Backlog milestone Jun 2, 2018
@bsclifton bsclifton changed the title Support allow-unitl-restart option of per-origin noscript settings Support allow-until-restart option of per-origin noscript settings Oct 29, 2018
@bsclifton bsclifton added feature/shields/!scripts Blocking JavaScript with Shields browser-laptop-parity labels Oct 29, 2018
@bsclifton bsclifton changed the title Support allow-until-restart option of per-origin noscript settings Support allow-until-restart option of per-origin noscript settings Oct 29, 2018
@bsclifton bsclifton mentioned this issue Oct 29, 2018
Merged
@yrliou yrliou removed their assignment Oct 31, 2018
@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Oct 31, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@karenkliu karenkliu self-assigned this Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karenkliu karenkliu

Labels
browser-laptop-parity feature/shields/!scripts Blocking JavaScript with Shields feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tildelowengrimm @bbondy @karenkliu @yrliou @bsclifton @rebron