Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement wallet_requestPermissions and wallet_getPermissions for compat with https://market.x.immutable.com/ and others #19274

Closed
bbondy opened this issue Nov 8, 2021 · 1 comment · Fixed by brave/brave-core#11568
Closed

Implement wallet_requestPermissions and wallet_getPermissions for compat with https://market.x.immutable.com/ and others #19274

bbondy opened this issue Nov 8, 2021 · 1 comment · Fixed by brave/brave-core#11568
Assignees
@bbondy
Labels
feature/web3/wallet Integrating Ethereum+ wallet support native-change This change is on the Chromium side, usually in C++ OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
Wallet
Milestone
1.35.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Nov 8, 2021 •
edited
Loading

https://eips.ethereum.org/EIPS/eip-2255

https://docs.metamask.io/guide/rpc-api.html#wallet-requestpermissions

https://market.x.immutable.com/ uses this and fails when connecting wallet because of it.

Test plan

Go through the whole connect and sign in process of Immutable X and make sure it acts the same as MetaMask.
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 8, 2021
@bbondy bbondy added this to Untriaged in Wallet via automation Nov 8, 2021
@bbondy bbondy moved this from Untriaged to Backlog in Wallet Nov 8, 2021
@bbondy bbondy added native-change This change is on the Chromium side, usually in C++ feature/web3/wallet Integrating Ethereum+ wallet support labels Nov 8, 2021
@bbondy bbondy changed the title Implement wallet_requestPermissions Implement wallet_requestPermissions and wallet_getPermissions Nov 18, 2021
@bbondy bbondy added the webcompat/not-shields-related Sites are breaking because of something other than Shields. label Nov 18, 2021
This was referenced Nov 19, 2021
Closed
Closed
@bbondy bbondy changed the title Implement wallet_requestPermissions and wallet_getPermissions Implement wallet_requestPermissions and wallet_getPermissions for compat with https://market.x.immutable.com/ and others Nov 19, 2021
@bbondy bbondy moved this from Backlog to In progress in Wallet Nov 21, 2021
@bbondy bbondy self-assigned this Nov 21, 2021
@bbondy bbondy mentioned this issue Dec 13, 2021
Merged
25 tasks
@bbondy bbondy moved this from In progress to In Review in Wallet Dec 13, 2021
Wallet automation moved this from In Review to Closed Dec 13, 2021
@bbondy bbondy added this to the 1.35.x - Nightly milestone Dec 13, 2021
@srirambv
Copy link
Contributor

Brave 1.35.93 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified able to connect to the Dapp similar to MetaMask
  • Verified disconnecting the wallet, able to reconnect with the same wallet by sign message
19274-Linux.mp4
19274-Windows.mp4
19274-macOS.mp4

This was referenced Feb 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/web3/wallet Integrating Ethereum+ wallet support native-change This change is on the Chromium side, usually in C++ OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
No open projects
Wallet
Closed
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

Implement provider methods: wallet_getPermissions, wallet_requestPermissions brave/brave-core
2 participants
@bbondy @srirambv