Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate bubble isn't shown when the non-English site is visited #19300

Closed
GeetaSarvadnya opened this issue Nov 9, 2021 · 5 comments · Fixed by brave/brave-core#10950
Closed

Comments

@GeetaSarvadnya
Copy link

Description

CR96 - Translate bubble isn't shown when the non-English site is visited

Steps to Reproduce

  1. Clean profile 1.33.69
  2. Open any non-English sites, https://www.deutschland.de/de or https://www.3zsistemi.si/
  3. Translate bubble isn't shown

Actual result:

The translate bubble isn't shown
image

Expected result:

Translate bubble should be shown

1.31.x
image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.33.69 Chromium: 96.0.4664.35 (Official Build) nightly (64-bit)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS Windows 10 Version 21H1 (Build 19043.1288)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @mkarolin @rebron

@mkarolin
Copy link
Contributor

mkarolin commented Nov 9, 2021

cc: @atuchin-m

@atuchin-m
Copy link
Contributor

The result of #18593

@rebron rebron added this to Untriaged Backlog in General Nov 9, 2021
@rebron rebron moved this from Untriaged Backlog to P3 Backlog in General Nov 9, 2021
@rebron rebron moved this from P3 Backlog to In progress in General Nov 9, 2021
@mkarolin
Copy link
Contributor

mkarolin commented Nov 9, 2021

This doesn't seem to be cr96-related as 1.32.x with cr96 (and without #18593) works the same way as 1.31.x does.

However, in 1.33.x with #18593 (but with #brave-translate-go disabled) I don't see the bubble that offers to install the Google Translate extension for languages like Chinese (http://news.cn/) or Hindi (https://www.aajtak.in/), so something isn't quite as expected, @atuchin-m?

@atuchin-m
Copy link
Contributor

atuchin-m commented Nov 10, 2021

This doesn't seem to be cr96-related as 1.32.x with cr96 (and without #18593) works the same way as 1.31.x does.

That's correct @mkarolin.

However, in 1.33.x with #18593 (but with #brave-translate-go disabled) I don't see the bubble that offers to install the Google Translate extension for languages like Chinese (http://news.cn/) or Hindi (https://www.aajtak.in/), so something isn't
quite as expected, @atuchin-m?

It's the same problem. The correct description of the bug is:
The bubble isn't shown when the feature is disabled and for the source/target language out of the brave supported list (for example for Chinese or Hindi).

General automation moved this from In progress to Completed Nov 10, 2021
@atuchin-m atuchin-m added this to the 1.34.x - Nightly milestone Nov 10, 2021
@GeetaSarvadnya GeetaSarvadnya changed the title CR96 - Translate bubble isn't shown when the non-English site is visited Translate bubble isn't shown when the non-English site is visited Nov 11, 2021
@stephendonner
Copy link

stephendonner commented Nov 15, 2021

Verified PASSED using

Brave 1.33.79 Chromium: 96.0.4664.45 (Official Build) beta (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. new profile
  2. launched Brave
  3. loaded each of the following URLs

Confirmed, for each, there was a dialog prompting to install Google Translate.

https://www.3zsistemi.si aol.de china.com https://www.deutschland.de/de
Screen Shot 2021-11-15 at 10 55 11 AM Screen Shot 2021-11-15 at 10 55 19 AM Screen Shot 2021-11-15 at 10 56 27 AM Screen Shot 2021-11-15 at 10 58 09 AM

Verified PASSED using

Brave 1.33.82 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 20H2 (Build 19042.1348)

Steps:

  1. new profile
  2. launched Brave
  3. loaded the following URLs

Confirmed, for each, there was a dialog prompting to install Google Translate.

https://www.3zsistemi.si https://it.euronews.com/tag/italia news.cn https://www.deutschland.de/de [.](https://www.aajtak.in/)
19300-3 19300-5 19300-1 19300-2 19300-4

Verified PASSED using

Brave 1.33.85 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

Steps:

  1. new profile
  2. launched Brave
  3. loaded the following URLs

Confirmed, for each, there was a dialog prompting to install Google Translate.

the-slovenia.com bmw.com/de taiwannews.com.tw ansa.it irna.ir
Screen Shot 2021-11-19 at 5 21 21 PM Screen Shot 2021-11-19 at 5 21 46 PM Screen Shot 2021-11-19 at 5 22 33 PM Screen Shot 2021-11-19 at 5 23 55 PM Screen Shot 2021-11-19 at 5 24 55 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment