Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0x message needs bottom padding when there is a warning message shown #19449

Closed
srirambv opened this issue Nov 15, 2021 · 1 comment · Fixed by brave/brave-core#11321
Closed
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects

Comments

@srirambv
Copy link
Contributor

Description

0x message needs bottom padding when there is a warning message shown

Steps to Reproduce

  1. Set slippage tolerance to 10% for a swap transaction
  2. 0x message has not bottom padding for the widget

Actual result:

image

Expected result:

Set margin-top:8px to fix the issue. may need to be done better for translated strings
image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.103 Chromium: 96.0.4664.45 (Official Build) (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @onyb

@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 15, 2021
@srirambv srirambv added this to Untriaged in Wallet via automation Nov 15, 2021
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 15, 2021
@bbondy bbondy moved this from Untriaged to Backlog in Wallet Nov 15, 2021
@muliswilliam muliswilliam moved this from Backlog to In progress in Wallet Nov 29, 2021
Wallet automation moved this from In progress to Closed Nov 30, 2021
@muliswilliam muliswilliam added this to the 1.35.x - Nightly milestone Dec 3, 2021
@muliswilliam muliswilliam self-assigned this Dec 3, 2021
@srirambv
Copy link
Contributor Author

srirambv commented Jan 12, 2022

Brave 1.35.82 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified 0x message has enough bottom padding on both widget and panel
Widget
Panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
No open projects
Wallet
Closed
Development

Successfully merging a pull request may close this issue.

3 participants