Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant notifications keeps showing up after page reload #1949

Closed
srirambv opened this issue Nov 1, 2018 · 4 comments
Closed

Grant notifications keeps showing up after page reload #1949

srirambv opened this issue Nov 1, 2018 · 4 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 1, 2018

Description

Grant notifications keeps showing up after page reload

Steps to Reproduce

  1. Clean profile
  2. Enable Rewards, check Claim Grant message is shown above wallet summary
  3. Check BR panel shows grant message, Click Ok to dismiss notification
  4. Reload brave://rewards page, grant message shows up on BR panel again

Actual result:

https://youtu.be/fZJrSkpBwsI

Expected result:

Message should only be shown once. Dismissing it and reloading the page should not show the message again

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @brave/legacy_qa

@srirambv srirambv added this to Untriaged Backlog in Rewards via automation Nov 1, 2018
@mandar-brave mandar-brave added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 1, 2018
@mandar-brave mandar-brave moved this from Untriaged Backlog to P3, P4, & P5 Backlog in Rewards Nov 1, 2018
@mandar-brave mandar-brave added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 1, 2018
@NejcZdovc
Copy link
Contributor

dupe of #1691

Rewards automation moved this from P3, P4, & P5 Backlog to Completed Nov 1, 2018
@NejcZdovc NejcZdovc removed this from Completed in Rewards Nov 1, 2018
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Nov 1, 2018
@NejcZdovc NejcZdovc added the closed/duplicate Issue has already been reported label Nov 1, 2018
@NejcZdovc NejcZdovc reopened this Nov 1, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Nov 1, 2018

@NejcZdovc not sure why this is closed as dupe. This one is specific to the grant showing up every time the page is reloaded and not having the notification stack up

@srirambv srirambv removed the closed/duplicate Issue has already been reported label Nov 1, 2018
@srirambv srirambv removed this from the Dupe / Invalid / Not actionable milestone Nov 1, 2018
@NejcZdovc
Copy link
Contributor

I though that this was a dupe since we had this problem when you reload site you could stack them to infinite #1691 (comment). But I see that you click OK. So what happens is that when you click OK you clear notification and when you reload page you fetch it again, so we show notification again. So if we want to fix this to show only once per grant we need to discuss it.

@NejcZdovc NejcZdovc added this to Untriaged Backlog in Rewards via automation Nov 1, 2018
@NejcZdovc NejcZdovc added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Nov 1, 2018
@NejcZdovc NejcZdovc moved this from Untriaged Backlog to Need investigation/Suggestions in Rewards Nov 1, 2018
@NejcZdovc NejcZdovc removed the bug label Nov 1, 2018
@kjozwiak kjozwiak added the QA/Yes label Nov 5, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Nov 5, 2018
@NejcZdovc NejcZdovc removed this from Need investigation/Suggestions in Rewards Jan 4, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 4, 2019
@NejcZdovc NejcZdovc added the closed/duplicate Issue has already been reported label Jan 4, 2019
@NejcZdovc
Copy link
Contributor

closing as dupe of #2454

@NejcZdovc NejcZdovc removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Jan 4, 2019
@kjozwiak kjozwiak removed QA/Yes feature/notifications feature/rewards priority/P4 Planned work. We expect to get to it "soon". labels Jan 8, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

5 participants