Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet - transfer of ERC-20 tokens rounded #19521

Closed
krijnsent opened this issue Nov 17, 2021 · 1 comment · Fixed by brave/brave-core#11938
Closed

Wallet - transfer of ERC-20 tokens rounded #19521

krijnsent opened this issue Nov 17, 2021 · 1 comment · Fixed by brave/brave-core#11938
Assignees
@onyb
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@krijnsent
Copy link

Description

Using the new wallet I tried to move all ERC-20 tokens from one Ethereum wallet to another. My wallet had 0,012654 wBTC, but when transferring, the amount got rounded to 0,0127, which obviously fails... Entering the amount with more decimals is not possible, it keeps getting rounded (up). That happens too when I select "100%".

Steps to Reproduce

  1. Try to transfer any amount with more than 4 decimals, the amount gets rounded. For ERC-20 tokens 18 decimals is somewhat standard...

Expected result:

Being able to input at least 18 decimal places.

Brave version (brave://version info)

v1.32.106
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 26, 2021
@bbondy bbondy added this to Untriaged in Wallet via automation Nov 26, 2021
@bbondy bbondy moved this from Untriaged to Backlog in Wallet Nov 26, 2021
@onyb onyb self-assigned this Nov 29, 2021
@onyb onyb added feature/web3/wallet Integrating Ethereum+ wallet support QA/Yes release-notes/include labels Nov 30, 2021
This was referenced Dec 1, 2021
Closed
Merged
@Douglashdaniel Douglashdaniel moved this from Backlog to Backlog (Desktop Front End) in Wallet Dec 14, 2021
@onyb onyb mentioned this issue Dec 29, 2021
Closed
4 tasks
@onyb onyb mentioned this issue Jan 10, 2022
Closed
@onyb onyb moved this from Backlog (Desktop Front End) to In progress in Wallet Jan 20, 2022
@onyb onyb mentioned this issue Jan 20, 2022
Merged
25 tasks
@onyb onyb moved this from In progress to In Review in Wallet Jan 21, 2022
Wallet automation moved this from In Review to Closed Jan 21, 2022
@onyb onyb added this to the 1.36.x - Nightly milestone Jan 21, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 21, 2022 •
edited

Brave 1.36.100 Chromium: 98.0.4758.102 (Official Build) beta (64-bit)
Revision 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)

@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@bbondy bbondy removed this from Closed in Wallet Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Fix inexact amounts in transction confirmation screen brave/brave-core
5 participants
@bbondy @onyb @srirambv @krijnsent and others