Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error modal text is generic when using non KYC bitFlyer wallet #19572

Closed
LaurenWags opened this issue Nov 18, 2021 · 2 comments · Fixed by brave/brave-core#11879
Closed

error modal text is generic when using non KYC bitFlyer wallet #19572

LaurenWags opened this issue Nov 18, 2021 · 2 comments · Fixed by brave/brave-core#11879

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #16652

For bitFlyer, when attempting to login with non KYC'd account, the error modal shows a "generic" error instead of the more specific one from brave/brave-core#10469.

Note - this is also how this works with 1.32.x.

Steps to Reproduce

  1. Clean profile 1.33.x, set region to Japan, use staging env
  2. Enable Rewards
  3. Choose to verify with bitFlyer
  4. Login with non KYC'd account

Actual result:

Screen Shot 2021-11-18 at 15 40 33

Expected result:

Expected the bitFlyer version of the kycRequiredModal from brave/brave-core#10469:

kycreq

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.33.83 Chromium: 96.0.4664.45 (Official Build) beta (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 11.6.1 (Build 20G224)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes 1.32.x
  • Can you reproduce this issue with the beta channel? yes 1.33.x
  • Can you reproduce this issue with the nightly channel? yes 1.34.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @szilardszaloki

@szilardszaloki
Copy link
Contributor

szilardszaloki commented Dec 13, 2021

Asked bitFlyer to make the appropriate changes on their end, so that when a non-KYC'd user hits Cancel on the linkage confirmation screen (which is the only option), they redirect them to brave://rewards/bitflyer/authorization?error=access_denied&state=<state>&error_description=User+does+not+meet+minimum+requirements (instead of brave://rewards/bitflyer/authorization?error=access_denied&state=<state>&error_description=Resource+owner+or+authorization+server+rejected+the+request.).

Brave Rewards automation moved this from In progress to Done Jan 19, 2022
@szilardszaloki szilardszaloki added this to the 1.36.x - Nightly milestone Jan 19, 2022
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 2, 2022
@LaurenWags
Copy link
Member Author

Verified passed with

Brave | 1.36.86 Chromium: 98.0.4758.87 (Official Build) beta (x86_64)
-- | --
Revision | e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS | macOS Version 12.2 (Build 21D49)

Verified STR from description.

English Japanese
English Japanese

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants