Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

premium content under dowjones not viewable until brave is restarted #2020

Closed
kjozwiak opened this issue Nov 7, 2018 · 8 comments · Fixed by brave/brave-core#892
Closed

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Nov 7, 2018

Description

Dowjones promotion isn't working correctly under both https://www.barrons.com/ and https://www.marketwatch.com/. Instead of being able to access the premium content

Barrons:

screen shot 2018-11-06 at 10 41 52 pm

Marketwatch:

screen shot 2018-11-06 at 10 46 23 pm

screen shot 2018-11-06 at 10 46 30 pm

Using the same accounts under muon, viewing the premium content works as expected. You'll also noticed that b-c is missing the X-Brave-Partner: dowjones header which muon has. I'm assuming that's the reason this isn't working under b-c as Dowjones expects the above header.

@GeetaSarvadnya reproduced this under Win 10 x64 as well.

Steps to Reproduce

  1. download the latest brave and rename the executable to either Brave-Browser-dowjones-barrons or Brave-Browser-dowjones-marketwatch
  2. once the promotion tab opens, claim the dowjones promotion by creating an account
  3. once the account as been created, log into the respectable site and attempt to view the premium content. On Barrons, this is the Magazine section. On MarketWatch, it's the Revolution Investing content.

Actual result:

screen shot 2018-11-06 at 9 49 48 pm

Expected result:

screen shot 2018-11-06 at 9 51 51 pm

Reproduces how often:

100% reproducible using the STR mentioned above.

Brave version (brave://version info)

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Haven't attempted the above under beta or dev but I'm assuming the same issue affects all three channels.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?

I tried the above with shields enabled and disabled and received the same results.

Additional Information

CCing @aekeus @davidtemkin @mandar-brave

@emerick
Copy link
Contributor

emerick commented Nov 7, 2018

@kjozwiak @GeetaSarvadnya I suspect this may require a restart of Brave (which we can certainly address). Could either of you confirm if this starts to work after a restart?

@srirambv
Copy link
Contributor

srirambv commented Nov 7, 2018

I could see the header after restart and page reload

@kjozwiak
Copy link
Member Author

kjozwiak commented Nov 7, 2018

@emerick yup, looks like restarting did the trick 👍 Probably should have tried this originally but figured it wasn't working as muon works without needing a restart. We should definitely fix this so it works without needing a restart as it's not obvious to users that a restart is required to view the paywalled content. I'll rename the issue so it's more clear.

Working on macOS 10.14 x64 with 0.56.9 Chromium: 70.0.3538.77 after restarting:

screen shot 2018-11-07 at 11 20 47 am

@emerick
Copy link
Contributor

emerick commented Nov 7, 2018

OK, sounds good.

@davidtemkin
Copy link

@emerick can you make it so a restart is not required?

@emerick
Copy link
Contributor

emerick commented Nov 7, 2018

@davidtemkin Yes definitely, investigating now.

@kjozwiak kjozwiak changed the title premium content under dowjones not viewable and still behind paywall premium content under dowjones not viewable until brave is restarted Nov 7, 2018
@davidtemkin
Copy link

great! thank you.

@rebron rebron added this to Untriaged Backlog in General Nov 7, 2018
General automation moved this from Untriaged Backlog to Completed Nov 12, 2018
@emerick emerick self-assigned this Nov 12, 2018
@rebron rebron modified the milestones: 1.x Backlog, 0.59.x - Nightly Nov 12, 2018
@kjozwiak
Copy link
Member Author

kjozwiak commented Dec 4, 2018

Went through verification using the following build under macOS 10.14 x64 - PASSED

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Mac OS X
  • went through both MW & Barrons and ensured that you can sign up and view the premium content without needing to restart
  • ensured that x-brave-partner: dowjones is also being sent in the headers

screen shot 2018-12-04 at 10 48 49 am

Verification passed on

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Windows
  • went through both MW & Barrons and ensured that you can sign up and view the premium content without needing to restart
  • ensured that x-brave-partner: dowjones is also being sent in the headers

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment