Shields block uploading images on GitHub

[srirambv]

Description

Shields block uploading images on GitHub

Steps to Reproduce

1. Keep default shields on GitHub
2. Create a new issue and try to upload an image via clipboard or attach files
3. Doesn't add it. Disable Adblocker, upload works

Actual result:

Shields block uploading images on GitHub

Expected result:

Should not block uploading files/adding images

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	0.57.6 Chromium: 71.0.3578.31 (Official Build) beta (64-bit)
Revision	c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS	All

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  Yes reproduces on both dev/beta

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

Reproduced by @kjozwiak on macOS

[srirambv]

Disable and enable shields allows you to add images on creating issues

[tildelowengrimm]

Couldn't repro on MacOS with version 0.57.4 [Chromium: 71.0.3578.31 (Official Build) dev]. More detailed repro steps maybe?

[cndouglas]

I can reproduce with a fresh profile. Turning off and on shields fixes the problem (seems like it's the cookie shield in particular).

Brave | 0.57.6 Chromium: 71.0.3578.31 (Official Build) beta(64-bit)
Revision | c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS | Mac OS X

1. Start with a fresh profile.
2. Go to https://github.com/brave/brave-browser/issues and login.
3. Create a new issue.
4. Try to upload an image to the issue.

[kjozwiak]

I couldn't reproduce this after a few attempts but I have ran into this several times. As @liunkae mentioned, disabling/re-enabling usually fixes the issue. There's definitely an issue here where the shields gets into a state where it starts blocking uploads. Re-opening as this is still obviously and issue even though it seems to be intermittent. Thanks for the info @liunkae 👍

[cndouglas]

Maybe related to #2092.

[cndouglas]

+1 from #2465 with 0.57.x. I have not had this problem since updating to 0.59.x dev, so it might have been fixed.

[srirambv]

+1 from @sobolevn & @lk-geimfari via #2485

[lukemulks]

+1 win10 x64

[manojmj92]

+1 on MacOS Mojave

[kjozwiak]

Ran into this again using 0.59.5 Chromium: 71.0.3578.80... Dragging & Dropping images into GH stopped working. Disabling the shields worked.

We need to find some reliable STR but seems like it's happening intermittently.

[NejcZdovc]

+1 it's happening for me all the time Version 0.59.2 Chromium: 71.0.3578.80 (Official Build) dev (64-bit)

[yochem]

Happens on macOS Mojave with other sites too, not just Github.
Version 0.57.18 Chromium: 71.0.3578.80 (Official Build) (64-bit).

[iefremov]

Looks like this is a dupe of #2252
Reveting https://github.com/brave/brave-core/pull/754/files fixes it for me.

[mbacchi]

[mbacchi]

The above is what I see in the developer console when shields are up ^^^

[HeadFox]

+1 happening on paper.dropbox too

[dy]

Yep. Getting both

new:1 Refused to connect to 'data:text/plain,' because it violates the following Content Security Policy directive: "connect-src 'self' uploads.github.com www.githubstatus.com collector.githubapp.com api.github.com www.google-analytics.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com wss://live.github.com".

Access to XMLHttpRequest at 'https://github-production-user-asset-6210df.s3.amazonaws.com/' from origin 'https://github.com' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: Redirect is not allowed for a preflight request.

The second is raised when copy-pasting an image into an issue input.

Turning shield off and one helps, exactly once.

[kjozwiak]

@tomlowenthal do you know if someone is working on this? Was moved into In Progress ~16 days ago but no one has been assigned.

[iefremov]

@tomlowenthal do you know if someone is working on this? Was moved into In Progress ~16 days ago but no one has been assigned.

This should be fixed here #2252
I'm working on this

[kjozwiak]

@iefremov awesome 👍

[cndouglas]

#2252 was fixed with brave/brave-core#1240, so this issue should also be fixed.

[iefremov]

Closing since #2252 should be fixed now.

[btlechowski]

Verification passed on

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Windows 7

Image pasted successfully. Upload from a file works also.

Verification PASSED on Mint 19.1 x64 VM using the following build:

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Linux

• uploaded ~20 images individually and ensured they was uploaded without any errors while shields were enabled
• uploaded ~40 images all at once and ensured they were uploaded without any errors while shields were enabled

Verified passed with

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Mac OS X

• Verified able to upload to GitHub using default shield settings