Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace network selector #20471

Closed
SergeyZhukovsky opened this issue Jan 12, 2022 · 1 comment · Fixed by brave/brave-core#12396
Closed

Replace network selector #20471

SergeyZhukovsky opened this issue Jan 12, 2022 · 1 comment · Fixed by brave/brave-core#12396
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes release-notes/include
Milestone
1.38.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

With a support of different chains we want to change a network selector from a dropdown to some kind of modal dialog. Check with @jamesmudgett on a design before doing that task. We have some draft in a spec, but there was a discussion in slack that we should do it different.
@SergeyZhukovsky SergeyZhukovsky added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 12, 2022
@SergeyZhukovsky SergeyZhukovsky added this to Untriaged in Wallet via automation Jan 12, 2022
@SergeyZhukovsky SergeyZhukovsky moved this from Untriaged to Backlog (Android) in Wallet Jan 12, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Feb 16, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Feb 24, 2022
Merged
25 tasks
Wallet automation moved this from Backlog (Android) to Closed Mar 2, 2022
@Pavneet-Sing Pavneet-Sing added this to the 1.38.x - Nightly milestone Mar 2, 2022
@bbondy bbondy removed this from Closed in Wallet Mar 18, 2022
@srirambv srirambv mentioned this issue Apr 20, 2022
Closed
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.38.103

  • Verified steps from brave/brave-core#12396
  • Verified network selector screen is shown when the network drop down is clicked
  • Verified selecting network and going back sets the new network
  • Encountered #22424 & #22425
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
20417-ARM.mp4
20417-Tab.mp4

@kjozwiak kjozwiak mentioned this issue Apr 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

20471 replace network selector brave/brave-core
4 participants
@bbondy @Pavneet-Sing @SergeyZhukovsky @srirambv