Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Formatting to not show metric values in Wallet #20535

Closed
Douglashdaniel opened this issue Jan 17, 2022 · 1 comment · Fixed by brave/brave-core#11982
Closed

Fix Formatting to not show metric values in Wallet #20535

Douglashdaniel opened this issue Jan 17, 2022 · 1 comment · Fixed by brave/brave-core#11982
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@Douglashdaniel
Copy link

Description

Large numbers are being displayed in Metric Values, we need to add better formatting for bigNumbers.

https://community.brave.com/t/digits-in-wallet-are-cryptic-numbers/327272
@Douglashdaniel Douglashdaniel added polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Jan 17, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jan 17, 2022
@Douglashdaniel Douglashdaniel added this to Untriaged in Wallet via automation Jan 17, 2022
@Douglashdaniel Douglashdaniel moved this from Untriaged to In progress in Wallet Jan 17, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Jan 25, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In progress to In Review in Wallet Jan 25, 2022
Wallet automation moved this from In Review to Closed Jan 25, 2022
@Douglashdaniel Douglashdaniel added this to the 1.36.x - Nightly milestone Jan 25, 2022
@srirambv
Copy link
Contributor

Brave 1.36.100 Chromium: 98.0.4758.102 (Official Build) beta (64-bit)
Revision 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)

@bbondy bbondy changed the title Fix Formatting to not show Metric Values in Wallet Fix Formatting to not show metric values in Wallet Mar 1, 2022
@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@bbondy bbondy removed this from Closed in Wallet Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Asset Details Crypto Value Formatting brave/brave-core
2 participants
@srirambv @Douglashdaniel