Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typed data signing issues with looksrare.org #20541

Closed
bbondy opened this issue Jan 18, 2022 · 1 comment · Fixed by brave/brave-core#11876
Closed

Fix typed data signing issues with looksrare.org #20541

bbondy opened this issue Jan 18, 2022 · 1 comment · Fixed by brave/brave-core#11876
Assignees
@bbondy
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
Wallet
Milestone
1.35.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Jan 18, 2022 •
edited
Loading

  • 0x is used as a value for bytes and we don't handle it
  • It uses uint and int values bigger than what we supported when wrapped in strings and in decimal format.

Test plan:

See the PR
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 18, 2022
@bbondy bbondy self-assigned this Jan 18, 2022
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 18, 2022
@bbondy bbondy added this to Untriaged in Wallet via automation Jan 18, 2022
@bbondy bbondy mentioned this issue Jan 18, 2022
Merged
25 tasks
Wallet automation moved this from Untriaged to Closed Jan 19, 2022
@bbondy bbondy added this to the 1.36.x - Nightly milestone Jan 19, 2022
@brave-builds brave-builds mentioned this issue Jan 19, 2022
Merged
7 tasks
@stephendonner stephendonner added the feature/web3/wallet Integrating Ethereum+ wallet support label Jan 19, 2022
@srirambv srirambv added QA/No and removed QA/Yes labels Jan 21, 2022
@srirambv
Copy link
Contributor

Marking as QA/No after discussing it with @bbondy. Confirmed that he was able to add NFT from looksrare.org

This was referenced Feb 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
No open projects
Wallet
Closed
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

Sign typed data v4 fixes for looksrare.org and other dapps brave/brave-core
4 participants
@stephendonner @bbondy @kjozwiak @srirambv