-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BraveShieldsAPIBrowserTest.AllowScriptsOnceIframe flakiness #20785
Comments
The issue is that a spare renderer doesn't get ContentSettings updates after creation. Without This looks like an edge case that Chromium doesn't handle, I'll try to upstream a fix for that. |
Upstreaming it here https://chromium-review.googlesource.com/c/chromium/src/+/3439874 |
We need a separate issue to rollback this change once upstream is fixed |
This was originally uplifted/scheduled to go into a |
BraveShieldsAPIBrowserTest.AllowScriptsOnceIframe
test is flaky, fails for a long time but is always(?) successful on retries. This change possibly made the flakiness more obvious, but it's also reproduced easily without this change.The test fails on the initial load step when all scripts should be blocked. It might be a test issue when a "block all" rule is not propagated to all renderers right away or something else.
Possibly related to upstream
NavigationThreadingOptimizations
feature.The text was updated successfully, but these errors were encountered: