Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BraveShieldsAPIBrowserTest.AllowScriptsOnceIframe flakiness #20785

Closed
goodov opened this issue Jan 29, 2022 · 4 comments · Fixed by brave/brave-core#12332
Closed

Fix BraveShieldsAPIBrowserTest.AllowScriptsOnceIframe flakiness #20785

goodov opened this issue Jan 29, 2022 · 4 comments · Fixed by brave/brave-core#12332

Comments

@goodov
Copy link
Member

goodov commented Jan 29, 2022

BraveShieldsAPIBrowserTest.AllowScriptsOnceIframe test is flaky, fails for a long time but is always(?) successful on retries. This change possibly made the flakiness more obvious, but it's also reproduced easily without this change.

The test fails on the initial load step when all scripts should be blocked. It might be a test issue when a "block all" rule is not propagated to all renderers right away or something else.
Possibly related to upstream NavigationThreadingOptimizations feature.

@goodov
Copy link
Member Author

goodov commented Feb 3, 2022

The issue is that a spare renderer doesn't get ContentSettings updates after creation. Without NavigationThreadingOptimizations feature we were able to update rules here, but with the feature enabled, our code cannot do the rules update perfectly.

This looks like an edge case that Chromium doesn't handle, I'll try to upstream a fix for that.

@goodov
Copy link
Member Author

goodov commented Feb 4, 2022

@iefremov
Copy link
Contributor

We need a separate issue to rollback this change once upstream is fixed

@kjozwiak
Copy link
Member

This was originally uplifted/scheduled to go into a 1.35.x HF but never ended up being released. It will go out via 1.36.x as we won't be having another 1.35.x release at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CI concerns
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants