Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not round amount values from swap quote #20872

Closed
onyb opened this issue Feb 3, 2022 · 1 comment · Fixed by brave/brave-core#12127
Closed

Do not round amount values from swap quote #20872

onyb opened this issue Feb 3, 2022 · 1 comment · Fixed by brave/brave-core#12127
Assignees
@onyb
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Wallet
Milestone
1.35.x - Release #2

Comments

@onyb
Copy link
Member

onyb commented Feb 3, 2022

Incorrect rounding can result in failure to estimate gas in case the value exceeds account balance. Example below 👇 :

video2689605635.mp4
@onyb onyb self-assigned this Feb 3, 2022
@onyb onyb added this to Untriaged in Wallet via automation Feb 3, 2022
@onyb onyb moved this from Untriaged to In Review in Wallet Feb 3, 2022
@onyb onyb mentioned this issue Feb 3, 2022
Merged
25 tasks
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 3, 2022
Wallet automation moved this from In Review to Closed Feb 3, 2022
@onyb onyb added this to the 1.37.x - Nightly milestone Feb 3, 2022
This was referenced Feb 3, 2022
Merged
Merged
@srirambv
Copy link
Contributor

srirambv commented Feb 9, 2022

Brave 1.35.101 Chromium: 98.0.4758.87 (Official Build) (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#12127
  • Verified decimal value isn't rounded off when focus is changed from input field
  • Verified the steps for ETH-> BAT and BAT-> ETH
20872-Linux.mp4
20872-Windows.mov
20872-macOS.mov

@kjozwiak kjozwiak mentioned this issue Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
No open projects
Wallet
Closed
Milestone
1.35.x - Release #2
Development

Successfully merging a pull request may close this issue.

fix(wallet): do not round amount values from swap quote brave/brave-core
4 participants
@bbondy @kjozwiak @onyb @srirambv