Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser crash when swap input value is large #20881

Closed
srirambv opened this issue Feb 4, 2022 · 2 comments · Fixed by brave/brave-core#12148
Closed

Browser crash when swap input value is large #20881

srirambv opened this issue Feb 4, 2022 · 2 comments · Fixed by brave/brave-core#12148
Assignees
Labels
bug crash feature/web3/wallet Integrating Ethereum+ wallet support needs-investigation A bug not 100% confirmed/fixed OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 4, 2022

Description

Browser crash when swap input value is large. Found this while testing brave/brave-core#12127

Steps to reproduce

  1. Install 1.37.25
  2. Open swap and enter value
  3. Update input value and browser crashes

Actual result

Browser.Crash.on.Swap.mp4

Prod Crash ID: https://share.backtrace.io/api/share/NXkA6RyPex2GQrQIHKLAtp0
Nightly Crash ID: https://share.backtrace.io/api/share/h7r2QdSlMygdM29NMPFZR3

Note: On prod when it crashes it goes back to Wallet onboarding screen. But when closed and reopened it shows locked screen. This doesn't happen on Nightly though

Expected result

No crash

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 11

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @SergeyZhukovsky @onyb

@srirambv srirambv added bug crash needs-investigation A bug not 100% confirmed/fixed release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 4, 2022
@srirambv srirambv added this to Untriaged in Wallet via automation Feb 4, 2022
@srirambv srirambv added this to Backlog in Android General via automation Feb 4, 2022
@onyb
Copy link
Member

onyb commented Feb 4, 2022

We merged brave/brave-core#11948 on Desktop to prevent users from entering values that do not comply with the decimals of the related asset (18 in this case). We should have something like that on Android.

@srirambv
Copy link
Contributor Author

srirambv commented Feb 9, 2022

Verification passed on the following devices running 1.35.101 x64 build

  • Verified steps from issue description
  • Verified no browser crash when swap input value is large
  • Verified Swap button shows Unknown Error when input value is large than available balance
Oppo Reno 5 (Android 11) Samsung Tab A (Android 10)
20881-Android.ARM.mp4
20881-.Android.Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash feature/web3/wallet Integrating Ethereum+ wallet support needs-investigation A bug not 100% confirmed/fixed OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
No open projects
Wallet
Closed
Development

Successfully merging a pull request may close this issue.

4 participants