Revert redirect-url feature #20892

ShivanKaul · 2022-02-04T17:22:53Z

Description

Revert $redirect-url feature added by #18542.

The intention was to allow resource replacements over the network if there's an adblock filter match. In other words, the redirect-filter option in a filter rule instructs the browser to load a replacement resource for the matching resource via a URL instead of locally - this was to be mainly used by Sugarcoated resources.

However, we've decided to not go ahead with loading adblock-related resources over the network and instead rely on component-bundled resources. Given that we don't plan on using redirect-url feature in the near-term, we should remove it to reduce security and bug surface. More details (including QA) in #18542.

@stephendonner

stephendonner · 2022-02-10T02:57:02Z

@ShivanKaul mind helping us with a test plan here? How does the following look, as a start?

Steps:

new profile
load brave://flags
verify no flag in brave://flags
open Developer Tools | Network panel
visit each of the sites listed from Support $redirect-urls in adblock #18542 (comment)

Confirm we don't replace requests (using internal redirects?), and those resources return a 200 OK.

cc @brave/legacy_qa

ShivanKaul · 2022-02-10T19:37:14Z

@stephendonner I think the QA plan would be reverse of #18542 (comment). I can send the DAT file again. What you mentioned in ^ sounds perfect, but given the deployed filter list it would be sufficient to check only the rules on https://raw.githubusercontent.com/brave/adblock-lists/master/brave-lists/brave-sugarcoat.txt i.e. check https://dell.com for ensighten.com/dell/marketing/code/280f261e277ca609b7450f5304929274.js and https://live.house.gov for google-analytics.com/analytics.js

Added this test plan to the PR.

stephendonner · 2022-02-24T16:59:07Z

@ShivanKaul please do send me the DAT file again.

Question: So we're not completely removing this, correct? (Given you pointed to rules for dell.com and live.house.gov.)

ShivanKaul · 2022-02-24T23:08:34Z

We are removing the feature where the sugarcoat replacement resource would be loaded remotely. Local replacements would still work i.e. for dell.com and live.house.gov, you shouldn't see it loaded via pcdn.brave.com, but just be a 200 loaded locally. This is a screenshot of what it should look like:

For all the other resources in #18542 (comment), no replacement at all should be happening, local or via PCDN (but that's just testing our brave component updater at this point).

stephendonner · 2022-02-28T19:29:17Z

Verified `PASSED` using

Brave	1.36.107 Chromium: 99.0.4844.45 (Official Build) (x86_64)
Revision	edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS	macOS Version 11.6.3 (Build 20G415)

Case 1: no `adblock-redirect` in `brave://flags`

Steps:

installed 1.36.107
launched Brave
loaded brave://flags
typed adblock-redirect

Confirmed no match for adblock-redirect

Case 2: regression-testing of removal

Steps:

installed 1.36.107
launched Brave
shut down
copied resources.json and rs-ABPFilterParserData.dat to /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/cffkpbalmllkdoenhmdmpbkajipdjfam/1.0.1228
relaunched Brave
clicked on hamburger menu, chose More tools -> Developer Tools
clicked on the Network pane
loaded reuters.com
loaded amazon.jobs
loaded fedex.com
loaded sky.it

Confirmed no async-sugarcoat-{hex}.js redirects for various ad/tracking resources.

`reuters.com`	`amazon.jobs`	`fedex.com`	`sky.it`

Case 3: sugarcoat inline script replacement

Steps:

installed 1.36.107
launched Brave
shut down
copied resources.json and rs-ABPFilterParserData.dat to /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/cffkpbalmllkdoenhmdmpbkajipdjfam/1.0.1228
relaunched Brave
clicked on hamburger menu, chose More tools -> Developer Tools
clicked on the Network pane
loaded https://shivankaul.com/adblock-redirect-test.html
clicked on hn.js
clicked on the Preview pane

Confirmed inline script replacement

1.36.107	1.35.104

stephendonner · 2022-03-01T01:30:06Z

Verified PASSED using

Brave	1.36.107 Chromium: 99.0.4844.45 (Official Build) (64-bit)
Revision	edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS	Linux

Case 1: no `adblock-redirect` in `brave://flags`

Steps:

installed 1.36.107
launched Brave
loaded brave://flags
typed adblock-redirect

Confirmed no match for adblock-redirect

Case 2: regression-testing of removal

Steps:

installed 1.36.107
launched Brave
shut down
copied resources.json and rs-ABPFilterParserData.dat to ~/.config/BraveSoftware/Brave-Browser/cffkpbalmllkdoenhmdmpbkajipdjfam/1.0.1229
relaunched Brave
clicked on hamburger menu, chose More tools -> Developer Tools
clicked on the Network pane
loaded reuters.com
loaded amazon.jobs
loaded fedex.com
loaded sky.it

Confirmed no async-sugarcoat-{hex}.js redirects for various ad/tracking resources.

`reuters.com`	`amazon.jobs`	`fedex.com`	`sky.it`

Case 3: sugarcoat inline script replacement

Steps:

installed 1.36.107
launched Brave
shut down
copied resources.json and rs-ABPFilterParserData.dat to ~/.config/BraveSoftware/Brave-Browser/cffkpbalmllkdoenhmdmpbkajipdjfam/1.0.1229
relaunched Brave
clicked on hamburger menu, chose More tools -> Developer Tools
clicked on the Network pane
loaded https://shivankaul.com/adblock-redirect-test.html
clicked on hn.js
clicked on the Preview pane

Confirmed inline script replacement

1.36.107	1.35.103

GeetaSarvadnya · 2022-03-01T10:07:45Z

Verification PASSED on


Brave | 1.36.107 Chromium: 99.0.4844.45 (Official Build) (64-bit)
-- | --
Revision | edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS | Windows 10 Version 21H2 (Build 19044.1526)

Case 1: no `adblock-redirect` in `brave://flags`

Steps:

installed 1.36.107
launched Brave
loaded brave://flags
typed adblock-redirect

Confirmed no match for adblock-redirect

Case 2: regression-testing of removal

Steps:

installed 1.36.107
launched Brave
shut down
copied resources.json and rs-ABPFilterParserData.dat to ~/.config/BraveSoftware/Brave-Browser/cffkpbalmllkdoenhmdmpbkajipdjfam/1.0.1229
relaunched Brave
clicked on hamburger menu, chose More tools -> Developer Tools
clicked on the Network pane
loaded reuters.com
loaded amazon.jobs
loaded fedex.com
loaded sky.it

Confirmed no async-sugarcoat-{hex}.js redirects for various ad/tracking resources.

`reuters.com`	`amazon.jobs`	`fedex.com`	`sky.it`

Case 3: sugarcoat inline script replacement

Steps:

installed 1.36.107
launched Brave
shut down
copied resources.json and rs-ABPFilterParserData.dat to ~/.config/BraveSoftware/Brave-Browser/cffkpbalmllkdoenhmdmpbkajipdjfam/1.0.1229
relaunched Brave
clicked on hamburger menu, chose More tools -> Developer Tools
clicked on the Network pane
loaded https://shivankaul.com/adblock-redirect-test.html
clicked on hn.js
clicked on the Preview pane

Confirmed inline script replacement

1.36.107	1.35.103

ShivanKaul added OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 4, 2022

ShivanKaul self-assigned this Feb 4, 2022

ShivanKaul mentioned this issue Feb 4, 2022

Revert "Redirect URL support for adblock" brave/brave-core#12064

Merged

25 tasks

ShivanKaul added QA/Yes release-notes/exclude and removed OS/Android Fixes related to Android browser functionality labels Feb 4, 2022

ShivanKaul closed this as completed in brave/brave-core#12064 Feb 4, 2022

stephendonner added this to the 1.37.x - Nightly milestone Feb 4, 2022

stephendonner added the QA/Test-Plan-Required label Feb 10, 2022

This was referenced Feb 22, 2022

Upgrade from Chromium 98 to Chromium 99. brave/brave-core#11829

Merged

Upgrade from Chromium 98 to Chromium 99 (uplift to 1.36.x). brave/brave-core#12326

Merged

kjozwiak modified the milestones: 1.37.x - Nightly, 1.36.x - Beta Feb 24, 2022

LaurenWags added the QA/Test-All-Platforms label Feb 24, 2022

stephendonner added the QA Pass-macOS label Feb 28, 2022

stephendonner added the QA Pass-Linux label Mar 1, 2022

GeetaSarvadnya added the QA Pass-Win64 label Mar 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert redirect-url feature #20892

Revert redirect-url feature #20892

ShivanKaul commented Feb 4, 2022 •

edited

stephendonner commented Feb 10, 2022

ShivanKaul commented Feb 10, 2022 •

edited

stephendonner commented Feb 24, 2022

ShivanKaul commented Feb 24, 2022 •

edited

stephendonner commented Feb 28, 2022

stephendonner commented Mar 1, 2022

GeetaSarvadnya commented Mar 1, 2022 •

edited

Revert redirect-url feature #20892

Revert redirect-url feature #20892

Comments

ShivanKaul commented Feb 4, 2022 • edited

Description

stephendonner commented Feb 10, 2022

ShivanKaul commented Feb 10, 2022 • edited

stephendonner commented Feb 24, 2022

ShivanKaul commented Feb 24, 2022 • edited

stephendonner commented Feb 28, 2022

Verified PASSED using

Case 1: no adblock-redirect in brave://flags

Case 2: regression-testing of removal

Case 3: sugarcoat inline script replacement

stephendonner commented Mar 1, 2022

Case 1: no adblock-redirect in brave://flags

Case 2: regression-testing of removal

Case 3: sugarcoat inline script replacement

GeetaSarvadnya commented Mar 1, 2022 • edited

Case 1: no adblock-redirect in brave://flags

Case 2: regression-testing of removal

Case 3: sugarcoat inline script replacement

ShivanKaul commented Feb 4, 2022 •

edited

ShivanKaul commented Feb 10, 2022 •

edited

ShivanKaul commented Feb 24, 2022 •

edited

Verified `PASSED` using

Case 1: no `adblock-redirect` in `brave://flags`

Case 1: no `adblock-redirect` in `brave://flags`

GeetaSarvadnya commented Mar 1, 2022 •

edited

Case 1: no `adblock-redirect` in `brave://flags`