Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong error when import accounts from locked device #21016

Closed
spylogsster opened this issue Feb 10, 2022 · 1 comment · Fixed by brave/brave-core#20680
Closed

Wrong error when import accounts from locked device #21016

spylogsster opened this issue Feb 10, 2022 · 1 comment · Fixed by brave/brave-core#20680
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/hardwaresupport feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.61.x - Release

Comments

@spylogsster
Copy link

Description

image

Steps to Reproduce

  1. Connected Ledger
  2. Try import accounts
  3. Do not unlock Ledger
  4. Check error message

Actual result:

The message has $1 instead of text

Expected result:

The message has valid error text

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@spylogsster spylogsster added this to Untriaged in Wallet via automation Feb 10, 2022
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 25, 2022
@bbondy bbondy moved this from Untriaged to Backlog in Wallet Feb 25, 2022
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Mar 3, 2022
@bbondy bbondy removed this from Backlog in Wallet Mar 18, 2022
@Douglashdaniel Douglashdaniel self-assigned this Oct 25, 2023
@Douglashdaniel Douglashdaniel added front-end-change This task is a front end task and doesn't need any C++ changes QA/Yes release-notes/include and removed feature/web3/wallet/core labels Oct 25, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Oct 25, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.61.x - Nightly milestone Oct 25, 2023
@srirambv
Copy link
Contributor

srirambv commented Nov 8, 2023

Verification passed on

Brave 1.61.67 Chromium: 119.0.6045.105 (Official Build) beta (64-bit)
Revision 09cc687dc27ccd8acafeebf5af1dc620b4d9cb22
OS Windows 11 Version 22H2 (Build 22621.2506)
  • Verified steps from brave/brave-core#20680
  • Verified importing Ethereum/Solana accounts from Ledger shows correct error message when Ledger device is locked
Ethereum Solana
brave_eq50Ov5xp3 brave_cZNjnYGG3h

@LaurenWags LaurenWags mentioned this issue Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/hardwaresupport feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.61.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Unlock Ledger Device Error brave/brave-core
6 participants
@bbondy @spylogsster @HEagle18 @srirambv @Douglashdaniel @brave-builds