Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS, Tor, and Onion icons should be the same (all open new tabs) #21092

Closed
stephendonner opened this issue Feb 14, 2022 · 3 comments · Fixed by brave/brave-core#12261
Closed

Comments

@stephendonner
Copy link

Description

IPFS, Tor, and Onion icons should be the same (all open new tabs)

Steps to Reproduce

  1. install 1.37.46
  2. launch Brave
  3. load ipns://ipfs.io
  4. click Use a Brave local IPFS node
  5. load https://ipfs.io
  6. look at the IPFS icon in the URL bar

Actual result:

The icon is different than our Tor and Onion icons, all of which open in a new tab.

example example
Screenshot 2022-02-14 123613 image

Expected result:

IPFS, Tor, and Onion should all have the same icon; not sure which is correct.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.37.46 Chromium: 98.0.4758.87 (Official Build) nightly (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Windows 10 Version 21H2 (Build 19044.1526)

cc @rebron @spylogsster

@stephendonner
Copy link
Author

Looks like #21028 was resolved (albeit with .onion rather than Onion, which is fine) along with this.

@spylogsster
Copy link

@stephendonner yes, #21028 can be closed

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 16, 2022

Verification PASSED on


Brave | 1.37.52 Chromium: 98.0.4758.102 (Official Build) nightly (64-bit)
-- | --
Revision | 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS | Windows 10 Version 21H2 (Build 19044.1526)


  • Verified the STR from the description and ensured IPFS, Tor and Onion icons are same

IPFS:
image

TOR:
image

Onion:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment