Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global fingerprint/ad-blocking configuration P3A questions #21345

Closed
DJAndries opened this issue Feb 25, 2022 · 2 comments · Fixed by brave/brave-core#12415
Closed

Add global fingerprint/ad-blocking configuration P3A questions #21345

DJAndries opened this issue Feb 25, 2022 · 2 comments · Fixed by brave/brave-core#12415

Comments

@DJAndries
Copy link
Collaborator

Description

Adding two new P3A questions for Shields global configuration:

What is the global fingerprinting shields setting?
0: Disabled
1: Standard
2: Aggressive

What is the global ad block shields setting?
0: Disabled
1: Standard
2: Strict

Miscellaneous Information:

Will raise PR soon.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 1, 2022

Verification PASSED on


Brave | 1.38.75 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
-- | --
Revision | 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS | Windows 10 Version 21H2 (Build 19044.1586)

Clean profile

Brave.Shields.AdBlockSetting

Case 1: Global shield settings_Standard_AdBlockSetting_PASSED
  • Confirmed Brave.Shields.AdBlockSetting response value is 1 when adblocking global shield settings is default to Standard
    image
Case 2: Global shield settings_Aggressive_AdBlockSetting_PASSED
  • Confirmed Brave.Shields.AdBlockSetting response value is 2 when adblocking global shield settings is set to Aggressive
    image
Case 3: Global shield settings_Disabled_AdBlockSetting_PASSED
  • Confirmed Brave.Shields.AdBlockSetting response value is 2 when adblocking global shield settings is set to Disabled
    image

Brave.Shields.FingerprintBlockSetting

Case 1: Global shield settings_Standard_FingerprintBlockSetting_PASSED
  • Confirmed Brave.Shields.FingerprintBlockSetting response value is 1 when adblocking global shield settings is default to Standard
    image
Case 2: Global shield settings_Disabled_FingerprintBlockSetting_PASSED
  • Confirmed Brave.Shields.FingerprintBlockSetting response value is 0 when adblocking global shield settings is set to Disabled

image

Case 3: Global shield settings_Strict, may break sites_FingerprintBlockSetting_PASSED
  • Confirmed Brave.Shields.FingerprintBlockSetting response value is 2 when adblocking global shield settings is set to Strict, may break sites

image

Upgrade profile

Adblocking_upgrade cases_PASSED
Fingerprintblocking_upgrade cases_PASSED

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 22, 2022

Verified using

Brave	1.38.105 Chromium: 101.0.4951.41 (Official Build) (64-bit) 
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Android 12; Build/SP1A.210812.016

Devices:
Samsung Galaxy Tab S7 | Android 12
Samsung Galaxy S21 | Android 12

Global Shield & FingerPrint Settings

  • Aggressive setting will have value of 2
  • Standard setting will have value of 1
  • Disabled setting will have value of 0

Upgraded Profile:

Case 1: Standard Setting: PASS
Case 2: Aggressive Settings: FAIL - #22063, #22064
Case 3: Disabled: FAIL #22064, #22063

Tablet Mobile
Screen Shot 2022-04-22 at 11 36 41 AM Screen Shot 2022-04-22 at 11 32 18 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants