Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the eth_subscribe method with the "newHeads" param #21350

Closed
ghost opened this issue Feb 26, 2022 · 5 comments · Fixed by brave/brave-core#16318
Closed

Support the eth_subscribe method with the "newHeads" param #21350

ghost opened this issue Feb 26, 2022 · 5 comments · Fixed by brave/brave-core#16318

Comments

@ghost
Copy link

ghost commented Feb 26, 2022

Description

When i want use the brave wallet on snowtrace, to make a transaction, snowtrace send the transaction to the wallet.
I click on confirm, and after that i have this error :
Failed to subscribe to new newBlockHeaders to confirm the transaction receipts. { "error": { "code": -32601, "message": "the method eth_subscribe does not exist" }, "id": 8, "jsonrpc": "2.0" }

Steps to Reproduce

  1. go on https://snowtrace.io/address/
  2. find a contract
  3. use function on write contract like "approve" : https://snowtrace.io/token/0xd586e7f844cea2f87f50152665bcbc2c279d8d70#writeContract
  4. accept the transaction on brave wallet

Actual result:

Failed to subscribe to new newBlockHeaders to confirm the transaction receipts. { "error": { "code": -32601, "message": "the method eth_subscribe does not exist" }, "id": 6, "jsonrpc": "2.0" }

Expected result:

transaction should be accepted

Brave version (brave://version info)

Version 1.35.103 Chromium: 98.0.4758.102 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • yes
@ghost ghost added the OS/Desktop label Feb 26, 2022
@kunal266
Copy link

kunal266 commented Feb 28, 2022

same error with ethglobal.com, I had to use chrome and install metamask to use the same

@vinh-perfectstorm
Copy link

same error with brave wallet

@rebron rebron added this to Untriaged in Wallet via automation Mar 4, 2022
@bbondy bbondy removed this from Untriaged in Wallet Mar 18, 2022
@bbondy
Copy link
Member

bbondy commented Mar 18, 2022

@nvonpentz if you have a chance could you look into what we need here in more detail?

@ghost
Copy link
Author

ghost commented Apr 27, 2022

Honestly, without disrespecting you, I have trouble understanding how this little bug can take so long.
And especially why you launched a wallet if we can't use it.
I'm a BAT holder and a brave user since years but honestly it pisses me off. Nobody will use your wallet if it's full of bugs and you take months to fix them.

@bbondy bbondy added feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support priority/P2 A bad problem. We might uplift this to the next planned release. and removed feature/web3/wallet/dapps labels Apr 28, 2022
@bbondy bbondy self-assigned this Oct 4, 2022
@bbondy bbondy added the QA/Yes label Dec 9, 2022
@bbondy bbondy modified the milestone: 1.48.x - Nightly Dec 9, 2022
@bbondy bbondy changed the title [wallet] the method eth_subscribe does not exist - snowtrace.io Support the eth_subscribe method with the "newHeads" param Dec 9, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 12, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Linux
  • Verified steps from brave/brave-core#16318
  • Verified eth_subscribe listens to new block head every 20 seconds
  • Verified eth_unsubscribe stops listening to events
21350.mp4

Verification passed on

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16318
  • Verified eth_subscribe listens to new block head every 20 seconds
  • Verified eth_unsubscribe stops listening to events
21350.mp4

Verification passed on

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (arm64)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16318
  • Verified eth_subscribe listens to new block head every 20 seconds
  • Verified eth_unsubscribe stops listening to events
21350.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants