Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a transaction metadata registry accessible to the panel #21763

Closed
onyb opened this issue Mar 18, 2022 · 1 comment
Closed

Implement a transaction metadata registry accessible to the panel #21763

onyb opened this issue Mar 18, 2022 · 1 comment
Assignees
@onyb
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/exclude

Comments

@onyb
Copy link
Member

onyb commented Mar 18, 2022

The idea is to store free-format data about transactions in Redux (example 0x swap quote) that is accessible in the panel. Whenever the quote is refreshed live in the panel, the metadata registry should be updated. See #21761 for a potential UX improvement this can enable.

This should replace the current swapQuote and swapQuoteError field in Redux, that are very context specific.
@onyb onyb self-assigned this Mar 18, 2022
@onyb
Copy link
Member Author

onyb commented Feb 23, 2023

This is no longer necessary with Swap V2, where #21761 is already available.

@onyb onyb closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onyb