Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display swap order sources and routing information #21761

Closed
onyb opened this issue Mar 18, 2022 · 1 comment · Fixed by brave/brave-core#15762
Closed

Display swap order sources and routing information #21761

onyb opened this issue Mar 18, 2022 · 1 comment · Fixed by brave/brave-core#15762
Assignees
@onyb
Labels
feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.48.x - Release

Comments

@onyb
Copy link
Member

onyb commented Mar 18, 2022

Swap order sources and their proportion can be accessed from the sources field of the full quote. The source names however must be mapped to human readable names or logos.

For order route, the information is available in the fillData field. Special care must be taken to handle case when there are multiple sources and complex order route (perhaps for exotic token pairs).

Paraswap inspiration:

⚠️ For us to display the route in the panel during transaction confirmation, it is essential that the quote is refreshed live within the panel, which is not the case today. Quotes on fast chains become obsolete very quickly, including the route.
@onyb onyb added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Mar 18, 2022
@onyb onyb mentioned this issue Mar 18, 2022
Closed
@onyb onyb added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Mar 18, 2022
@onyb onyb self-assigned this Nov 9, 2022
@onyb onyb mentioned this issue Nov 9, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Nov 28, 2022
@onyb onyb added QA/Yes release-notes/include and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support labels Nov 28, 2022
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Jan 10, 2023
@srirambv
Copy link
Contributor

Verified as part of #26632 (comment)

@LaurenWags LaurenWags mentioned this issue Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

feat(swap): add Swap v2 integration brave/brave-core
4 participants
@bbondy @onyb @srirambv @brave-builds